Skip to content

Commit 3a7a266

Browse files
committed
Disable Mixed Comparisons by default
Enabling this feature without Post-Lookup surprisingly can reduce our support for certain queries. This is also a partial revert of Iad455b26. We again pass the argument explicitly as we did before the change that made this feature enabled by default. Change-Id: I81a945f02a94dddbe458cadc539e75afb588d9d7 Reviewed-on: https://gerrit.readyset.name/c/readyset/+/8024 Reviewed-by: Sidney Cammeresi <[email protected]> Tested-by: Buildkite CI
1 parent cd2b828 commit 3a7a266

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

readyset-features.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"command-line": "--feature-mixed-comparisons",
1414
"environment-variable": "FEATURE_MIXED_COMPARISONS",
1515
"description": "Enable support for mixing equality and range comparisons on query parameters.",
16-
"default": true
16+
"default": false
1717
},
1818
{
1919
"feature_id": "3",

readyset-server/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ pub struct WorkerOptions {
654654
#[arg(
655655
long,
656656
env = "FEATURE_MIXED_COMPARISONS",
657-
default_value = "true",
657+
default_value = "false",
658658
default_missing_value = "true",
659659
num_args = 0..=1,
660660
action = ArgAction::Set,

0 commit comments

Comments
 (0)