Lifetime cleanup to prepare for Rust 1.84

Clippy is increasing its love of anonymous lifetimes.

Change-Id: I10bcbeb976539d6e1035cab3c33b309c89099cb3
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/8450
Tested-by: Buildkite CI
Reviewed-by: Jason Brown <[email protected]>

Author: rs-sac

benchmarks/src/reporting/storage/postgres.rs

@@ -28,8 +28,8 @@ impl PostgresStorage {
         Ok(PostgresStorage { client })
     }
 
-    async fn write_session<'a>(
-        client: &Transaction<'a>,
+    async fn write_session(
+        client: &Transaction<'_>,
         session: &BenchSession,
     ) -> anyhow::Result<BenchSessionId> {
         let query = r#"
@@ -53,8 +53,8 @@ impl PostgresStorage {
         Ok(session_id)
     }
 
-    async fn write_aggregate<'a>(
-        client: &Transaction<'a>,
+    async fn write_aggregate(
+        client: &Transaction<'_>,
         session_id: BenchSessionId,
         metric: &str,
         unit: &str,

database-utils/src/connection.rs

@@ -679,7 +679,7 @@ pub enum Transaction<'a> {
     PostgresPool(deadpool_postgres::Transaction<'a>),
 }
 
-impl<'a> QueryableConnection for Transaction<'a> {
+impl QueryableConnection for Transaction<'_> {
     async fn query_drop<Q>(&mut self, stmt: Q) -> Result<(), DatabaseError>
     where
         Q: AsQuery + AsRef<str> + Send + Sync,
@@ -785,7 +785,7 @@ impl<'a> QueryableConnection for Transaction<'a> {
     }
 }
 
-impl<'a> Transaction<'a> {
+impl Transaction<'_> {
     /// Consumes the transaction, committing the operations.
     pub async fn commit(self) -> Result<(), DatabaseError> {
         match self {

nom-sql/src/dialect.rs

@@ -47,7 +47,7 @@ where
     }
 }
 
-impl<'a, T> DialectDisplay for CommaSeparatedList<'a, T>
+impl<T> DialectDisplay for CommaSeparatedList<'_, T>
 where
     T: DialectDisplay,
 {

readyset-mysql/src/backend.rs

@@ -378,8 +378,8 @@ macro_rules! handle_error {
     };
 }
 
-async fn handle_readyset_result<'a, W>(
-    result: noria_connector::QueryResult<'a>,
+async fn handle_readyset_result<W>(
+    result: noria_connector::QueryResult<'_>,
     writer: QueryResultWriter<'_, W>,
 ) -> io::Result<()>
 where
@@ -427,8 +427,8 @@ where
     }
 }
 
-async fn handle_upstream_result<'a, W>(
-    result: upstream::QueryResult<'a>,
+async fn handle_upstream_result<W>(
+    result: upstream::QueryResult<'_>,
     writer: QueryResultWriter<'_, W>,
 ) -> io::Result<()>
 where
@@ -478,8 +478,8 @@ where
     }
 }
 
-async fn handle_execute_result<'a, W>(
-    result: Result<QueryResult<'a, LazyUpstream<MySqlUpstream>>, Error>,
+async fn handle_execute_result<W>(
+    result: Result<QueryResult<'_, LazyUpstream<MySqlUpstream>>, Error>,
     writer: QueryResultWriter<'_, W>,
 ) -> io::Result<()>
 where
@@ -504,8 +504,8 @@ where
     }
 }
 
-async fn handle_query_result<'a, W>(
-    result: Result<QueryResult<'a, LazyUpstream<MySqlUpstream>>, Error>,
+async fn handle_query_result<W>(
+    result: Result<QueryResult<'_, LazyUpstream<MySqlUpstream>>, Error>,
     writer: QueryResultWriter<'_, W>,
 ) -> QueryResultsResponse
 where

readyset-server/src/controller/migrate/mod.rs

@@ -342,7 +342,7 @@ pub struct MigrationPlan<'df> {
     dmp: DomainMigrationPlan,
 }
 
-impl<'df> MigrationPlan<'df> {
+impl MigrationPlan<'_> {
     /// Apply the migration plan to the provided `Leader`.
     ///
     /// If the plan fails, the `Leader`'s state is left unchanged; however, no attempt

readyset-util/src/shared_cache.rs

@@ -227,7 +227,7 @@ where
 
     /// Return the *key* associated with the given value within either the local, or the shared
     /// versions of this cache. O(size), and performs no memoization
-    pub async fn key_for_val<'a, U>(&'a self, val: &U) -> Option<K>
+    pub async fn key_for_val<U>(&self, val: &U) -> Option<K>
     where
         V: PartialEq<U>,
         K: Clone,

replicators/src/mysql_connector/snapshot.rs

@@ -137,7 +137,7 @@ fn tx_opts() -> TxOpts {
     tx_opts
 }
 
-impl<'a> MySqlReplicator<'a> {
+impl MySqlReplicator<'_> {
     /// Load all the `CREATE TABLE` statements for the tables in the MySQL database. Returns the the
     /// transaction that holds the DDL locks for the tables and the Vector of tables that requires
     /// snapshot.