Cache mod dependency metadata checks

Author: realdoomsboygaming

Natives/installer/modpack/CurseForgeAPI.m

@@ -135,6 +135,7 @@ - (NSDictionary *)modManagerRecordForFile:(NSDictionary *)file projectID:(NSNumb
         @"size": size,
         @"gameVersion": [self minecraftVersionForFile:file],
         @"dependencies": [self normalizedCurseForgeDependencies:([file[@"dependencies"] isKindOfClass:NSArray.class] ? file[@"dependencies"] : @[])],
+        @"dependencyMetadataCheckedAt": @([[NSDate date] timeIntervalSince1970]),
         @"enabled": @YES
     };
 }

Natives/installer/mods/ModManagerAPI.m

@@ -6,6 +6,8 @@
 
 static NSString * const kModSourceModrinth = @"modrinth";
 static NSString * const kModSourceCurseForge = @"curseforge";
+static NSString * const kDependencyMetadataCheckedAtKey = @"dependencyMetadataCheckedAt";
+static NSTimeInterval const kDependencyMetadataRefreshInterval = 24.0 * 60.0 * 60.0;
 
 @interface ModManagerAPI ()
 @property(nonatomic) ModrinthAPI *modrinth;
@@ -144,6 +146,38 @@ - (NSDictionary *)modrinthVersionForID:(NSString *)versionID {
     return [version isKindOfClass:NSDictionary.class] ? version : nil;
 }
 
+- (NSNumber *)currentTimestamp {
+    return @([[NSDate date] timeIntervalSince1970]);
+}
+
+- (BOOL)modNeedsDependencyMetadataRefresh:(NSDictionary *)mod {
+    if (![mod isKindOfClass:NSDictionary.class] || [mod[@"missing"] boolValue]) {
+        return NO;
+    }
+
+    NSArray *dependencies = [mod[@"dependencies"] isKindOfClass:NSArray.class] ? mod[@"dependencies"] : nil;
+    if (dependencies) {
+        NSNumber *checkedAt = [mod[kDependencyMetadataCheckedAtKey] respondsToSelector:@selector(doubleValue)] ? mod[kDependencyMetadataCheckedAtKey] : nil;
+        if (!checkedAt) {
+            return NO;
+        }
+        return [[NSDate date] timeIntervalSince1970] - checkedAt.doubleValue > kDependencyMetadataRefreshInterval;
+    }
+
+    NSString *source = mod[@"source"];
+    if ([source isEqualToString:kModSourceCurseForge]) {
+        return mod[@"fileId"] && mod[@"projectId"];
+    }
+    if ([source isEqualToString:kModSourceModrinth]) {
+        NSString *versionID = mod[@"versionId"];
+        NSString *sha = mod[@"sha1"];
+        return ([versionID isKindOfClass:NSString.class] && versionID.length > 0) ||
+            ([sha isKindOfClass:NSString.class] && sha.length > 0) ||
+            [mod[@"path"] isKindOfClass:NSString.class];
+    }
+    return NO;
+}
+
 - (NSString *)jsonStringForArray:(NSArray *)array {
     if (![array isKindOfClass:NSArray.class]) {
         return @"[]";
@@ -498,6 +532,7 @@ - (NSMutableDictionary *)recordFromNormalizedVersion:(NSDictionary *)version loc
     if (!record[@"installedAt"] && mod[@"installedAt"]) {
         record[@"installedAt"] = mod[@"installedAt"];
     }
+    record[kDependencyMetadataCheckedAtKey] = [self currentTimestamp];
     return record;
 }
 
@@ -518,7 +553,7 @@ - (NSMutableDictionary *)recordFromNormalizedVersion:(NSDictionary *)version loc
     NSMutableSet<NSString *> *seenModrinthHashes = [NSMutableSet new];
 
     for (NSDictionary *mod in mods) {
-        if (![mod isKindOfClass:NSDictionary.class] || [mod[@"missing"] boolValue]) {
+        if (![self modNeedsDependencyMetadataRefresh:mod]) {
             continue;
         }
 

Natives/installer/mods/ModManagerStore.m

@@ -456,7 +456,7 @@ - (NSDictionary *)installPlanForFiles:(NSArray<NSDictionary *> *)files error:(NS
         NSString *title = [file[@"title"] isKindOfClass:NSString.class] ? file[@"title"] : fileName;
 
         NSMutableDictionary *record = [NSMutableDictionary new];
-        NSArray *recordKeys = @[@"source", @"projectId", @"versionId", @"fileId", @"title", @"versionName", @"summary", @"iconUrl", @"fileName", @"sha1", @"size", @"gameVersion", @"loaders", @"dependencies", @"datePublished"];
+        NSArray *recordKeys = @[@"source", @"projectId", @"versionId", @"fileId", @"title", @"versionName", @"summary", @"iconUrl", @"fileName", @"sha1", @"size", @"gameVersion", @"loaders", @"dependencies", @"datePublished", @"dependencyMetadataCheckedAt"];
         for (NSString *key in recordKeys) {
             id value = file[key];
             if (value && value != NSNull.null) {

Natives/installer/mods/ModManagerViewController.m

@@ -18,6 +18,7 @@ @interface ModManagerViewController ()
 @property(nonatomic) UISearchController *searchController;
 @property(nonatomic) NSArray<NSMutableDictionary *> *mods;
 @property(nonatomic) BOOL checkingUpdates;
+@property(nonatomic) BOOL checkingDependencies;
 @end
 
 @implementation ModManagerViewController
@@ -86,6 +87,12 @@ - (void)setCheckingUpdates:(BOOL)checkingUpdates {
     }
 }
 
+- (void)setCheckingDependencies:(BOOL)checkingDependencies {
+    _checkingDependencies = checkingDependencies;
+    self.tableView.userInteractionEnabled = !checkingDependencies;
+    self.navigationItem.prompt = checkingDependencies ? @"Checking dependencies..." : nil;
+}
+
 - (void)actionCheckUpdates {
     if (self.checkingUpdates) {
         return;
@@ -253,6 +260,7 @@ - (NSDictionary *)currentInstalledModMatchingMod:(NSDictionary *)mod {
 
 - (void)refreshProviderMetadataForMod:(NSDictionary *)mod completion:(void (^)(NSDictionary *currentMod))completion {
     NSArray *installedMods = [self.store installedMods];
+    self.checkingDependencies = YES;
     dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
         NSArray *records = [self.api refreshedMetadataForInstalledMods:installedMods profileInfo:self.store.profileInfo];
         NSError *error = self.api.lastError;
@@ -263,6 +271,7 @@ - (void)refreshProviderMetadataForMod:(NSDictionary *)mod completion:(void (^)(N
             }
         }
         dispatch_async(dispatch_get_main_queue(), ^{
+            self.checkingDependencies = NO;
             if (error) {
                 [self presentError:error];
                 if (completion) {