diff --git a/x/multi-staking/types/proposal.go b/x/multi-staking/types/proposal.go index 6b9b803..9798cb5 100644 --- a/x/multi-staking/types/proposal.go +++ b/x/multi-staking/types/proposal.go @@ -118,7 +118,7 @@ func (cbtp *UpdateBondWeightProposal) ValidateBasic() error { return sdkerrors.Wrap(ErrInvalidUpdateBondWeightProposal, "proposal bond token cannot be blank") } - if !cbtp.UpdatedBondWeight.IsPositive() { + if cbtp.UpdatedBondWeight.LT(math.LegacyZeroDec()) { return sdkerrors.Wrap(ErrInvalidUpdateBondWeightProposal, "proposal bond token weight must be positive") } diff --git a/x/multi-staking/types/proposal_test.go b/x/multi-staking/types/proposal_test.go index 1e66acb..3ea6520 100644 --- a/x/multi-staking/types/proposal_test.go +++ b/x/multi-staking/types/proposal_test.go @@ -91,11 +91,11 @@ func (suite *ProposalTestSuite) TestUpdateBondWeightProposal() { }{ // Valid tests {msg: "Change bond token weight", title: "test", description: "test desc", denom: "token", bondWeight: math.LegacyOneDec(), expectPass: true}, + {msg: "Change bond token weight - zero weight", title: "test", description: "test desc", denom: "token", bondWeight: math.LegacyZeroDec(), expectPass: true}, // Invalid tests {msg: "Change bond token weight - invalid token", title: "test", description: "test desc", denom: "", bondWeight: math.LegacyOneDec(), expectPass: false}, {msg: "Change bond token weight - negative weight", title: "test", description: "test desc", denom: "token", bondWeight: math.LegacyMustNewDecFromStr("-1"), expectPass: false}, - {msg: "Change bond token weight - zero weight", title: "test", description: "test desc", denom: "token", bondWeight: math.LegacyZeroDec(), expectPass: false}, } for i, tc := range testCases {