chore: add comment on getParent

jorenrui · jorenrui · commit 2089454fd97e · 2024-02-10T16:15:22.000+08:00
diff --git a/lib/entity.js b/lib/entity.js
@@ -176,6 +176,8 @@ export default class Entity {
     return await engine.interpret(this)
   }
 
+  /* Note: I don't this getParent() is needed,
+    since el. variables should use the current element's uuid instead. */
   getParent() {
     if (this.isParent()) {
       return this
@@ -194,6 +196,7 @@ export default class Entity {
   }
 
   generateEntityUUID() {
+    // Suggestion: we can use crypto.randomUUID(). Tho crypto only works in secure contexts
     return 'Entity' + Date.now() + Math.floor(Math.random() * 10000)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,8 @@ export default class Entity {`
`176`	`176`	`return await engine.interpret(this)`
`177`	`177`	`}`
`178`	`178`
	`179`	`+ /* Note: I don't this getParent() is needed,`
	`180`	`+ since el. variables should use the current element's uuid instead. */`
`179`	`181`	`getParent() {`
`180`	`182`	`if (this.isParent()) {`
`181`	`183`	`return this`
`@@ -194,6 +196,7 @@ export default class Entity {`
`194`	`196`	`}`
`195`	`197`
`196`	`198`	`generateEntityUUID() {`
	`199`	`+ // Suggestion: we can use crypto.randomUUID(). Tho crypto only works in secure contexts`
`197`	`200`	`return 'Entity' + Date.now() + Math.floor(Math.random() * 10000)`
`198`	`201`	`}`
`199`	`202`