Merge pull request #363 from Leonidas-from-XIV/remove-stanza-package-test

Remove `require-package` label support

Author: Leonidas-from-XIV

CHANGES.md

@@ -22,6 +22,9 @@
   is 4.08 to 4.13 now (#345, @Leonidas-from-XIV)
 - Do not install deprecated `mdx` binary anymore (#274, @gpetiot)
 - Remove deprecated `rule` command (#312, @gpetiot)
+- Remove support for `require-package` label, use the `mdx` stanza in dune
+  instead. This label was only used for the `rule` command and can now be
+  safely removed. (#363, @Leonidas-from-XIV)
 
 #### Security
 

lib/label.ml

@@ -84,7 +84,6 @@ type t =
   | Skip
   | Non_det of non_det option
   | Version of Relation.t * Ocaml_version.t
-  | Require_package of string
   | Set of string * string
   | Unset of string
   | Block_kind of block_kind
@@ -107,7 +106,6 @@ let pp ppf = function
   | Non_det (Some Nd_command) -> Fmt.string ppf "non-deterministic=command"
   | Version (op, v) ->
       Fmt.pf ppf "version%a%a" Relation.pp op Ocaml_version.pp v
-  | Require_package p -> Fmt.pf ppf "require-package=%s" p
   | Set (v, x) -> Fmt.pf ppf "set-%s=%s" v x
   | Unset x -> Fmt.pf ppf "unset-%s" x
   | Block_kind bk -> pp_block_kind ppf bk
@@ -176,8 +174,6 @@ let interpret label value =
   | "file" -> requires_eq_value ~label ~value (fun x -> File x)
   | "part" -> requires_eq_value ~label ~value (fun x -> Part x)
   | "env" -> requires_eq_value ~label ~value (fun x -> Env x)
-  | "require-package" ->
-      requires_eq_value ~label ~value (fun x -> Require_package x)
   | l when is_prefix ~prefix:"set-" l ->
       requires_eq_value ~label ~value (fun x ->
           Set (split_prefix ~prefix:"set-" l, x))

lib/label.mli

@@ -41,7 +41,6 @@ type t =
   | Skip
   | Non_det of non_det option
   | Version of Relation.t * Ocaml_version.t
-  | Require_package of string
   | Set of string * string
   | Unset of string
   | Block_kind of block_kind