Merge pull request #440 from Julow/warning-false-positive

More precise warning detection

Author: gpetiot

CHANGES.md

@@ -4,6 +4,10 @@
 
 - Handle the error-blocks syntax (#439, @jonludlam, @gpetiot)
 
+#### Fixed
+
+- Reduce false-positives while detecting warnings (#440, @Julow)
+
 ### 2.3.1
 
 #### Added

lib/test/mdx_test.ml

@@ -203,9 +203,11 @@ let rec error_padding = function
       let xs = error_padding xs in
       x :: xs
 
+let contains_warnings l =
+  String.is_prefix ~affix:"Warning" l || String.is_infix ~affix:"\nWarning" l
+
 let eval_ocaml ~(block : Block.t) ?syntax ?root c ppf errors =
   let cmd = block.contents |> remove_padding in
-  let contains_warnings = String.is_infix ~affix:"Warning" in
   let error_lines =
     match eval_test ?root ~block c cmd with
     | Ok lines -> List.filter contains_warnings lines

test/bin/mdx-test/expect/warnings/test-case.md

@@ -29,3 +29,29 @@ Warning 9 [missing-record-field-pattern]: the following labels are not bound in
 y
 Either bind these labels explicitly or add '; _' to the pattern.
 ```
+
+Test against some false positives:
+
+```ocaml
+let x = [ "Warning" ]
+```
+
+```ocaml
+module Warning = struct
+  type t = Warning
+end
+
+let warning = Warning.Warning
+```
+
+Intended false positive:
+
+```ocaml
+let x =
+  if true then
+    prerr_endline "Warning: Assert failed";
+  [ "foo" ]
+```
+```mdx-error
+Warning: Assert failed
+```