Commented out values get eaten

[yminsky]

I just noticed this in the Async chapter, where some commented out code got removed entirely in the corrected file. I think the corrected file should never remove comments.

[let-def]

Can you give one example?

[yminsky]

Hmm. Can't seem to replicate. I'm not sure what I was seeing, but will re-open if/when I experience it.

[yminsky]

Just got it again. When I comment out this section:

[%%expect{|an error happened|};
ocaml {|- : unit = ()|}];;

[@@@part "36"];;
(*
exception Ignore_me;;
[%%expect ocaml {|exception Ignore_me|}];;
let swallow_some_errors exn_to_raise =
  let child_monitor  = Monitor.create  () in
  let parent_monitor = Monitor.current () in
  Stream.iter
    (Monitor.detach_and_get_error_stream child_monitor)
    ~f:(fun error ->
      match Monitor.extract_exn error with
      | Ignore_me -> printf "ignoring exn\n"
      | _ -> Monitor.send_exn parent_monitor error);
  within' ~monitor:child_monitor (fun () ->
    after (Time.Span.of_sec 0.25)
    >>= fun () -> raise exn_to_raise)
;;
[%%expect ocaml {|val swallow_some_errors : exn -> 'a Conduit_async.io = <fun>|}];;
*)

[@@@part "37"];;
Deferred.any [ after (Time.Span.of_sec 0.5)
             ; swallow_some_errors Not_found ]
;;
[%%expect{|Exception: (monitor.ml.Error Not_found ("Caught by monitor (id 61)")).|}];;
[@@@part "38"];;
Deferred.any [ after (Time.Span.of_sec 0.5)
             ; swallow_some_errors Ignore_me ]
;;

in the concurrent programming section, then topscript wants to delete it.

[yminsky]

And this shows the state of the code and the result of the diff against the corrected file side-by-side. The red shows that the commented out bit is deleted.

[yminsky]

Did we ever get a resolution on this?

[let-def]

It shouldn't occur with master. Is it still happening?

[yminsky]

I'm currently using the opam release. Is this feature released yet? If not, I'll look to matter and check again.

…

On Oct 4, 2017 7:28 AM, "Frédéric Bour" ***@***.***> wrote: It shouldn't occur with master. Is it still happening? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AArqJmI7yDCdvFkQ07yKU4l3SeYxOz5Aks5so2vugaJpZM4O121v> .

[let-def]

No it is not released yet.

[yminsky]

OK. I'll try it out and report back. If it all looks good, could we get an opam release out after that? y

…

On Wed, Oct 4, 2017 at 8:36 AM, Frédéric Bour ***@***.***> wrote: No it is not released yet. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AArqJr79YLb7yDypvawbNcm2KuxpkswYks5so3vEgaJpZM4O121v> .

[let-def]

Sure.