Skip to content

Commit 7c3603c

Browse files
author
Rafid Bin Mostofa
committed
ci: adjust and add comments
1 parent e0a18ec commit 7c3603c

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/scripts/removed-slices/removed-slices

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ oldref="$1"
2424
curref="$(git rev-parse --short HEAD)"
2525
exitcode=0
2626

27-
# Check for deleted or renamed slice definition files and error out early.
27+
# Check for deleted or renamed slice definition files.
2828
deleted_files=()
2929
while IFS= read -r f; do
3030
deleted_files+=( "$f" )

.github/workflows/removed-slices.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,7 @@ jobs:
4141
- name: "Check for removed slices"
4242
run: |
4343
ln -s "${{ env.files_main }}/.github/scripts/removed-slices/removed-slices" .
44+
# For pull request events, use github.base_ref as the old git ref.
45+
# For push events, the github.event.before value contains the SHA of
46+
# the most recent commit on ref before the push.
4447
./removed-slices "${{ github.base_ref || github.event.before }}"

0 commit comments

Comments
 (0)