feat: emit cbor bytes in bucket create event

Author: dtbuchholz

src/BucketManager.sol

@@ -13,20 +13,21 @@ contract BucketManager is IBucketManager {
     function create() external {
         KeyValue[] memory metadata = new KeyValue[](0);
         LibBucket.create(msg.sender, metadata);
-        emit BucketCreated(msg.sender);
+        bytes memory data = LibBucket.create(msg.sender, metadata);
+        emit BucketCreated(msg.sender, data);
     }
 
     /// @dev See {IBucketManager-create}.
     function create(address owner) external {
         KeyValue[] memory metadata = new KeyValue[](0);
-        LibBucket.create(owner, metadata);
-        emit BucketCreated(owner);
+        bytes memory data = LibBucket.create(owner, metadata);
+        emit BucketCreated(owner, data);
     }
 
     /// @dev See {IBucketManager-create}.
     function create(address owner, KeyValue[] memory metadata) external {
-        LibBucket.create(owner, metadata);
-        emit BucketCreated(owner);
+        bytes memory data = LibBucket.create(owner, metadata);
+        emit BucketCreated(owner, data);
     }
 
     /// @dev See {IBucketManager-list}.

src/interfaces/IBucketManager.sol

@@ -1,22 +1,27 @@
 // SPDX-License-Identifier: MIT OR Apache-2.0
 pragma solidity ^0.8.26;
 
-import {
-    AddParams, CreateBucketParams, KeyValue, Kind, Machine, Query, Value, WriteAccess
-} from "../types/BucketTypes.sol";
+import {AddParams, KeyValue, Kind, Machine, Query, Value} from "../types/BucketTypes.sol";
 
 /// @dev Hoku Bucket actor EVM interface for managing objects, and querying object or storage stats.
 /// See Rust implementation for details:
 /// https://github.com/hokunet/ipc/blob/develop/fendermint/actors/objectstore/src/actor.rs
 interface IBucketManager {
     /// @dev Emitted when a bucket is created.
-    // TODO: It'd be nice to emit the bucket t2 address, but decoding the CBOR is too expensive.
-    event BucketCreated(address indexed owner);
+    /// @param owner The owner.
+    /// @param data The CBOR encoded response—array with two values including the bucket's ID and robust (t2) addresses.
+    event BucketCreated(address indexed owner, bytes data);
 
     /// @dev Emitted when an object is added to a bucket.
+    /// @param owner The owner.
+    /// @param bucket The bucket's robust t2 address.
+    /// @param key The object key.
     event ObjectAdded(address indexed owner, string indexed bucket, string indexed key);
 
     /// @dev Emitted when an object is removed from a bucket.
+    /// @param owner The owner.
+    /// @param bucket The bucket's robust t2 address.
+    /// @param key The object key.
     event ObjectRemoved(address indexed owner, string indexed bucket, string indexed key);
 
     /// @dev Create a bucket. Uses the sender as the owner.

src/util/LibBucket.sol

@@ -211,15 +211,15 @@ library LibBucket {
     /// @dev Create a bucket.
     /// @param owner The owner.
     /// @param metadata The metadata.
-    function create(address owner, KeyValue[] memory metadata) external {
+    function create(address owner, KeyValue[] memory metadata) external returns (bytes memory) {
         CreateBucketParams memory createParams = CreateBucketParams({
             owner: owner,
             kind: Kind.Bucket,
             writeAccess: WriteAccess.OnlyOwner, // Bucket access control always uses credit approvals
             metadata: metadata
         });
         bytes memory params = encodeCreateBucketParams(createParams);
-        LibWasm.writeToWasmActor(ADM_ACTOR_ID, METHOD_CREATE_EXTERNAL, params);
+        return LibWasm.writeToWasmActor(ADM_ACTOR_ID, METHOD_CREATE_EXTERNAL, params);
     }
 
     /// @dev List all buckets owned by an address.