Skip to content

Commit 8fca9fe

Browse files
committed
chore: cleanups after rebase
1 parent c4388ac commit 8fca9fe

File tree

3 files changed

+24
-17
lines changed

3 files changed

+24
-17
lines changed

README.md

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,14 @@ Deploy the Bucket Manager contract to the localnet subnet:
186186
PRIVATE_KEY=<0x...> forge script script/BucketManager.s.sol --tc DeployScript --sig 'run(string)' local --rpc-url localnet_subnet --broadcast -g 100000 -vv
187187
```
188188

189+
##### Blobs
190+
191+
Deploy the Blob Manager contract to the localnet subnet:
192+
193+
```shell
194+
PRIVATE_KEY=<0x...> forge script script/BlobManager.s.sol --tc DeployScript --sig 'run(string)' local --rpc-url testnet_subnet --broadcast -g 100000 -vv
195+
```
196+
189197
#### Testnet
190198

191199
##### Hoku ERC20
@@ -209,7 +217,7 @@ PRIVATE_KEY=<0x...> forge script script/Faucet.s.sol --tc DeployScript --sig 'ru
209217

210218
##### Credit
211219

212-
Deploy the Credit contract to the testnet subnet:
220+
Deploy the Credit Manager contract to the testnet subnet:
213221

214222
```shell
215223
PRIVATE_KEY=<0x...> forge script script/CreditManager.s.sol --tc DeployScript --sig 'run(string)' testnet --rpc-url testnet_subnet --broadcast -g 100000 -vv
@@ -223,6 +231,14 @@ Deploy the Bucket Manager contract to the testnet subnet:
223231
PRIVATE_KEY=<0x...> forge script script/BucketManager.s.sol --tc DeployScript --sig 'run(string)' testnet --rpc-url testnet_subnet --broadcast -g 100000 -vv
224232
```
225233

234+
##### Blobs
235+
236+
Deploy the Blob Manager contract to the testnet subnet:
237+
238+
```shell
239+
PRIVATE_KEY=<0x...> forge script script/BlobManager.s.sol --tc DeployScript --sig 'run(string)' testnet --rpc-url testnet_subnet --broadcast -g 100000 -vv
240+
```
241+
226242
#### Devnet
227243

228244
The devnet does not have the concept of a "parent" chain, so all RPCs would use `--rpc-url devnet`
@@ -855,8 +871,8 @@ setting the `BLOBS` environment variable to the deployed address:
855871

856872
```
857873
BLOBS=$(PRIVATE_KEY=$PRIVATE_KEY forge script script/BlobManager.s.sol \
858-
--tc DeployScript 0 \
859-
--sig 'run(uint8)' \
874+
--tc DeployScript \
875+
--sig 'run(string)' local \
860876
--rpc-url localnet_subnet \
861877
--broadcast -g 100000 \
862878
| grep "0: contract BlobManager" | awk '{print $NF}')

script/BlobManager.s.sol

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,25 @@
11
// SPDX-License-Identifier: MIT OR Apache-2.0
22
pragma solidity ^0.8.26;
33

4+
import {Strings} from "@openzeppelin/contracts/utils/Strings.sol";
45
import {Script} from "forge-std/Script.sol";
56
import {console2 as console} from "forge-std/console2.sol";
67

78
import {BlobManager} from "../src/BlobManager.sol";
8-
import {Environment} from "../src/types/CommonTypes.sol";
99

1010
contract DeployScript is Script {
1111
string constant PRIVATE_KEY = "PRIVATE_KEY";
1212

1313
function setUp() public {}
1414

15-
function run(Environment env) public returns (BlobManager) {
15+
function run(string memory network) public returns (BlobManager) {
1616
if (vm.envExists(PRIVATE_KEY)) {
1717
uint256 privateKey = vm.envUint(PRIVATE_KEY);
18-
if (env == Environment.Local) {
19-
console.log("Deploying to local network");
20-
} else if (env == Environment.Testnet) {
21-
console.log("Deploying to testnet network");
22-
} else {
23-
revert("Mainnet is not supported");
24-
}
2518
vm.startBroadcast(privateKey);
26-
} else if (env == Environment.Foundry) {
27-
console.log("Deploying to foundry");
19+
} else if (Strings.equal(network, "local")) {
2820
vm.startBroadcast();
2921
} else {
30-
revert("PRIVATE_KEY not set");
22+
revert("PRIVATE_KEY not set in non-local environment");
3123
}
3224

3325
BlobManager blobs = new BlobManager();

test/BlobManager.t.sol

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,13 @@ import {console2 as console} from "forge-std/console2.sol";
77

88
import {DeployScript as BlobDeployer} from "../script/BlobManager.s.sol";
99
import {BlobManager} from "../src/BlobManager.sol";
10-
import {Environment} from "../src/types/CommonTypes.sol";
1110

1211
// TODO: add integration tests once it's possible in CI
1312
contract BlobManagerTest is Test, BlobManager {
1413
BlobManager internal blobs;
1514

1615
function setUp() public virtual {
1716
BlobDeployer blobsDeployer = new BlobDeployer();
18-
blobs = blobsDeployer.run(Environment.Foundry);
17+
blobs = blobsDeployer.run("local");
1918
}
2019
}

0 commit comments

Comments
 (0)