Handle SCSI NAA addresses for SCSI disks

Author: dbackeus

TODO.md

@@ -9,6 +9,5 @@
 mdadm --create --verbose /dev/md0 --level=0 --raid-devices=2 /dev/nvme0n1 /dev/nvme1n1
 mdadm --detail /dev/md0 # uuid:1a462672:bd83888c:df8fa57e:6b38f998
 
-- Handle SCSI(?) SSD devices which report their wwid as 0x<hex-code>, Talos needs this to become naa.<hex-code> instead (see end of https://chatgpt.com/share/e/68ac4c53-3eec-800e-93de-fc4e97d2bf33 for feedback)
 - Remove deprecated setting#schematic_id
 - In case talos-manager SSH key isn't available we should error out when trying to enter rescue mode

app/models/server.rb

@@ -52,6 +52,16 @@ def bootstrappable?
     bootstrap_metadata.fetch(:bootstrappable)
   end
 
+  # Convert SCSI NAA addresses to Talos readable WWIDs, more at:
+  # https://chatgpt.com/share/e/68ac4c53-3eec-800e-93de-fc4e97d2bf33
+  def bootstrap_disk_wwid=(value)
+    if value.start_with?("0x")
+      super "naa.#{value.delete_prefix('0x').downcase}"
+    else
+      super
+    end
+  end
+
   def talos_type
     name.include?("control-plane") ? "controlplane" : "worker"
   end

spec/models/server_spec.rb

@@ -89,4 +89,15 @@
       expect(server.reload).not_to be_accessible
     end
   end
+
+  describe "#bootstrap_disk_wwid=" do
+    it "converts SCSI WWIDs to the correct format" do
+      server = Server.new(bootstrap_disk_wwid: "0x5002538c6003052d")
+      expect(server.bootstrap_disk_wwid).to eq "naa.5002538c6003052d"
+
+      # sanity check regular WWIDs are not changed
+      server = Server.new(bootstrap_disk_wwid: "eui.00000000000000178ce38e02001d0b64")
+      expect(server.bootstrap_disk_wwid).to eq "eui.00000000000000178ce38e02001d0b64"
+    end
+  end
 end