Change default factory schematic to a proper reference

Author: dbackeus

app/controllers/talos_image_factory_settings_controller.rb

@@ -4,11 +4,10 @@ def update
 
     talos_image_factory_setting_params = params.require(:talos_image_factory_setting).permit(
       :version,
-      :schematic_id,
+      :talos_image_factory_schematic_id,
     )
 
     if @talos_image_factory_setting.update(talos_image_factory_setting_params)
-      # redirect_to settings_path, status: 303, notice: "Talos Image Factory settings updated successfully."
       flash.now[:talos_image_factory_update_notice] = "Talos Image Factory settings updated successfully."
       render :edit
     else

app/models/server.rb

@@ -125,15 +125,19 @@ def reset
   end
 
   def bootstrap_image_url(platform: "metal", talos_version: TalosImageFactorySetting.singleton.version)
-    schematic_id =
-      talos_image_factory_schematic&.schematic_id || TalosImageFactory.create_schematic_with_talos_config.fetch("id")
+    existing_schematic_id =
+      talos_image_factory_schematic&.schematic_id ||
+      TalosImageFactorySetting.singleton.talos_image_factory_schematic&.schematic_id
+    schematic_id = existing_schematic_id || TalosImageFactory.create_schematic_with_talos_config.fetch("id")
 
     "#{TalosImageFactory::BASE_URL}/image/#{schematic_id}/#{talos_version}/#{platform}-#{architecture}.raw.zst"
   end
 
   def upgrade_image_url(platform: "metal", talos_version: TalosImageFactorySetting.singleton.version)
-    schematic_id =
-      talos_image_factory_schematic&.schematic_id || TalosImageFactory.create_schematic_with_talos_config.fetch("id")
+    existing_schematic_id =
+      talos_image_factory_schematic&.schematic_id ||
+      TalosImageFactorySetting.singleton.talos_image_factory_schematic&.schematic_id
+    schematic_id = existing_schematic_id || TalosImageFactory.create_schematic_with_talos_config.fetch("id")
 
     "factory.talos.dev/#{platform}-installer/#{schematic_id}:#{talos_version}"
   end

app/models/talos_image_factory_schematic.rb

@@ -3,6 +3,9 @@ class TalosImageFactorySchematic < ApplicationRecord
   validates_uniqueness_of :name
   validates_presence_of :body
   validate :validate_and_normalize_and_post_body, if: :body_changed?
+  validates_presence_of :schematic_id # must be validated after body is validated and posted
+
+  has_one :talos_image_factory_setting, dependent: :nullify
 
   # private
 

app/models/talos_image_factory_setting.rb

@@ -7,12 +7,10 @@ def self.singleton
     first_or_create!
   end
 
-  validates :version, presence: true
-  validates :version, uniqueness: true
-  validates :version, format: { with: /\Av\d+\.\d+\.\d+\z/, message: "must be in the format vX.Y.Z" }
-  validates :version, length: { maximum: 20 }
+  belongs_to :talos_image_factory_schematic, optional: true
 
   attribute :version, :string, default: "v1.10.4"
 
   validates_presence_of :version
+  validates :version, format: { with: /\Av\d+\.\d+\.\d+\z/, message: "must be in the format vX.Y.Z" }
 end

app/views/servers/prepare_bootstrap.html.erb

@@ -23,7 +23,7 @@
           f.select(
             :talos_image_factory_schematic_id,
             TalosImageFactorySchematic.order(:name).pluck(:name, :id),
-            { include_blank: "none", selected: TalosImageFactorySetting.singleton.schematic_id },
+            { include_blank: "none", selected: TalosImageFactorySetting.singleton.talos_image_factory_schematic_id },
             class: "w-full mb-4",
             label: "Talos Image Factory Schematic",
             required: false,

app/views/talos_image_factory_settings/_form.html.erb

@@ -3,7 +3,7 @@
     <%= f.select :version, sorted_talos_versions, { include_blank: false }, label: "Default Talos Version", required: false %>
     <%=
       f.select(
-        :schematic_id,
+        :talos_image_factory_schematic_id,
         TalosImageFactorySchematic.order(:name).pluck(:name, :id),
         { include_blank: "none" },
         label: "Default Talos Schematic",

db/migrate/20251001101556_change_talos_image_factory_settings_schematic_id_into_reference.rb

@@ -0,0 +1,17 @@
+class ChangeTalosImageFactorySettingsSchematicIdIntoReference < ActiveRecord::Migration[8.0]
+  def up
+    add_reference :talos_image_factory_settings, :talos_image_factory_schematic, foreign_key: true
+
+    setting = TalosImageFactorySetting.singleton
+    schematic_id = setting.try(:schematic_id)
+    talos_image_factory_schematic = schematic_id && TalosImageFactorySchematic.find_by(schematic_id:)
+
+    if talos_image_factory_schematic
+      TalosImageFactorySetting.singleton.update!(talos_image_factory_schematic_id: talos_image_factory_schematic.id)
+    end
+  end
+
+  def down
+    remove_reference :talos_image_factory_settings, :talos_image_factory_schematic, foreign_key: true
+  end
+end

db/schema.rb

@@ -26,6 +26,24 @@
     expect(server.errors[:name]).to include "has already been taken"
   end
 
+  describe "#bootstrap_image_url" do
+    it "returns a URL to a Talos image with the correct schematic ID and Talos version" do
+      talos_version = "v1.10.5"
+      server = servers(:cloud_bootstrappable)
+      server.update! talos_image_factory_schematic: talos_image_factory_schematics(:default)
+      expected_url = "#{TalosImageFactory::BASE_URL}/image/#{talos_image_factory_schematics(:default).schematic_id}/#{talos_version}/metal-#{server.architecture}.raw.zst"
+      expect(server.bootstrap_image_url(talos_version:)).to eq(expected_url)
+    end
+
+    it "uses the default Talos version and schematic_id if none are provided" do
+      server = Server.new
+      default_setting = TalosImageFactorySetting.singleton
+      default_setting.update! talos_image_factory_schematic: talos_image_factory_schematics(:default)
+      expected_url = "#{TalosImageFactory::BASE_URL}/image/#{default_setting.talos_image_factory_schematic&.schematic_id}/#{default_setting.version}/metal-#{server.architecture}.raw.zst"
+      expect(server.bootstrap_image_url).to eq(expected_url)
+    end
+  end
+
   describe "#bootstrap!" do
     it "writes a Talos image to an eligble disk, saves metadata and reboots" do
       talos_version = "v1.10.5"