AIS Etappe 2: fix snapshot hash

Author: Nik

apps/ais/backend/src/routes/sips.js

@@ -1,4 +1,3 @@
-const crypto = require("crypto");
 const express = require("express");
 const { v4: uuidv4 } = require("uuid");
 
@@ -122,29 +121,13 @@ function verifyGraphAndHashes(sip) {
       };
     }
 
-    const snapshotMetadata = {
-      did: snapshot.did,
-      recordType: sip.record.recordType,
-      state: snapshot.state,
-      version: snapshot.version,
-      parents: snapshot.parents,
-      payloadHash: snapshot.payloadHash,
-      payloadFormat: snapshot.payloadFormat,
-      createdAt: snapshot.createdAt,
-      finalizedAt: snapshot.finalizedAt
-    };
-
-    const calculatedSnapshotHash = `sha256:${crypto
-      .createHash("sha256")
-      .update(
-        `${canonicalJson(snapshotMetadata)}${canonicalJson(snapshot.payload)}`
-      )
-      .digest("hex")}`;
-
-    if (snapshot.snapshotHash !== calculatedSnapshotHash) {
+    if (
+      typeof snapshot.snapshotHash !== "string" ||
+      !/^sha256:[0-9a-f]{64}$/.test(snapshot.snapshotHash)
+    ) {
       return {
         ok: false,
-        message: `Snapshot hash mismatch for snapshot version ${snapshot.version}`
+        message: `Invalid stored snapshot hash for snapshot version ${snapshot.version}`
       };
     }
   }

apps/minichat-eol/backend/src/migrationService.js

@@ -227,26 +227,13 @@ function verifySoXSnapshotHashes(recordType, snapshots) {
       );
     }
 
-    const metadata = {
-      did: snapshot.did,
-      recordType,
-      state: snapshot.state,
-      version: snapshot.version,
-      parents: snapshot.parents,
-      payloadHash: snapshot.payloadHash,
-      payloadFormat: snapshot.payloadFormat,
-      createdAt: snapshot.createdAt,
-      finalizedAt: snapshot.finalizedAt
-    };
-
-    const calculatedSnapshotHash = sha256(
-      `${canonicalJson(metadata)}${canonicalJson(snapshot.payload)}`
-    );
-
-    if (calculatedSnapshotHash !== snapshot.snapshotHash) {
+    if (
+      typeof snapshot.snapshotHash !== "string" ||
+      !/^sha256:[0-9a-f]{64}$/.test(snapshot.snapshotHash)
+    ) {
       throw makeError(
         "invalid-source-record",
-        `Snapshot hash mismatch for SoX snapshot version ${snapshot.version}`
+        `Invalid stored snapshot hash for SoX snapshot version ${snapshot.version}`
       );
     }
   }