sort files by default, as always true and to get reproducible builds

Author: TomasVotruba

src/FileSystem/FilesFinder.php

@@ -33,7 +33,7 @@ public function __construct(
      * @param string[] $suffixes
      * @return string[]
      */
-    public function findInDirectoriesAndFiles(array $source, array $suffixes = [], bool $sortByName = true): array
+    public function findInDirectoriesAndFiles(array $source, array $suffixes = []): array
     {
         $filesAndDirectories = $this->filesystemTweaker->resolveWithFnmatch($source);
 
@@ -69,7 +69,7 @@ function (string $file): bool {
 
         // filtering files in directories collection
         $directories = $this->fileAndDirectoryFilter->filterDirectories($filesAndDirectories);
-        $filteredFilePathsInDirectories = $this->findInDirectories($directories, $suffixes, $sortByName);
+        $filteredFilePathsInDirectories = $this->findInDirectories($directories, $suffixes);
 
         $filePaths = [...$filteredFilePaths, ...$filteredFilePathsInDirectories];
         return $this->unchangedFilesFilter->filterFilePaths($filePaths);
@@ -102,7 +102,7 @@ private function isStartWithShortPHPTag(string $fileContent): bool
      * @param string[] $suffixes
      * @return string[]
      */
-    private function findInDirectories(array $directories, array $suffixes, bool $sortByName = true): array
+    private function findInDirectories(array $directories, array $suffixes): array
     {
         if ($directories === []) {
             return [];
@@ -112,11 +112,8 @@ private function findInDirectories(array $directories, array $suffixes, bool $so
             ->files()
             // skip empty files
             ->size('> 0')
-            ->in($directories);
-
-        if ($sortByName) {
-            $finder->sortByName();
-        }
+            ->in($directories)
+            ->sortByName();
 
         if ($suffixes !== []) {
             $suffixesPattern = $this->normalizeSuffixesToPattern($suffixes);