Skip to content

Commit 9f68305

Browse files
committed
sort files by default, as always true and to get reproducible builds
1 parent 80aca73 commit 9f68305

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/FileSystem/FilesFinder.php

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public function __construct(
3333
* @param string[] $suffixes
3434
* @return string[]
3535
*/
36-
public function findInDirectoriesAndFiles(array $source, array $suffixes = [], bool $sortByName = true): array
36+
public function findInDirectoriesAndFiles(array $source, array $suffixes = []): array
3737
{
3838
$filesAndDirectories = $this->filesystemTweaker->resolveWithFnmatch($source);
3939

@@ -69,7 +69,7 @@ function (string $file): bool {
6969

7070
// filtering files in directories collection
7171
$directories = $this->fileAndDirectoryFilter->filterDirectories($filesAndDirectories);
72-
$filteredFilePathsInDirectories = $this->findInDirectories($directories, $suffixes, $sortByName);
72+
$filteredFilePathsInDirectories = $this->findInDirectories($directories, $suffixes);
7373

7474
$filePaths = [...$filteredFilePaths, ...$filteredFilePathsInDirectories];
7575
return $this->unchangedFilesFilter->filterFilePaths($filePaths);
@@ -102,7 +102,7 @@ private function isStartWithShortPHPTag(string $fileContent): bool
102102
* @param string[] $suffixes
103103
* @return string[]
104104
*/
105-
private function findInDirectories(array $directories, array $suffixes, bool $sortByName = true): array
105+
private function findInDirectories(array $directories, array $suffixes): array
106106
{
107107
if ($directories === []) {
108108
return [];
@@ -112,11 +112,8 @@ private function findInDirectories(array $directories, array $suffixes, bool $so
112112
->files()
113113
// skip empty files
114114
->size('> 0')
115-
->in($directories);
116-
117-
if ($sortByName) {
118-
$finder->sortByName();
119-
}
115+
->in($directories)
116+
->sortByName();
120117

121118
if ($suffixes !== []) {
122119
$suffixesPattern = $this->normalizeSuffixesToPattern($suffixes);

0 commit comments

Comments
 (0)