Skip to content

Refactor RecursersClient.Set to not need a separate ID parameter #117

Description

@jdkaplan

The refactoring in #100 resulted in a function that takes a recurser ID (as int64) and a recurser struct (Recurser, which has the same ID as a field). We can simplify this by changing it to only need the struct parameter.

func (r *RecursersClient) Set(ctx context.Context, _ int64, recurser *Recurser) error {

The name being an underscore acts as proof that the parameter is totally unused.

This might be a good time to try the new go fix inliner!

(Extracted from #100 (comment))

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions