RHAIENG-4029: add tier-2 integration test for agentic RAG agent (#101)

* feat(agentic_rag): add tier-2 integration deployment test

Add integration test that builds, deploys, and health-checks the
LangGraph Agentic RAG agent on OpenShift. Unlike tier-1 agents, this
test validates RAG-specific env vars (EMBEDDING_MODEL, VECTOR_STORE_ID,
EMBEDDING_DIMENSION, VECTOR_STORE_PROVIDER) are present before
attempting deployment, and writes them to .env so the Helm deploy
target passes them through to the pod.

Also fixes the `make test` target to ignore the integration directory,
preventing import errors when running unit tests locally.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: add env var comment and redact VECTOR_STORE_ID in integration logs

Clarify why agent.yaml-optional vars are required in the integration
test, and extend _REDACT_PATTERNS to cover VECTOR_STORE_ID which may
contain connection strings with credentials.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address CodeRabbit review feedback

Validate EMBEDDING_DIMENSION as int before writing to .env, and add
quoted-format redaction pattern for VECTOR_STORE_ID to cover Helm
--set usage in deployment logs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor: address teammate review feedback

- Move helpers (_write_env_file, INTERNAL_REGISTRY) and fixtures
  (agent_dir, agent_name, deployed_agent) to conftest.py so the test
  file contains only test functions (andrewdonheiser)
- Add broad `except Exception` fallback in deployed_agent fixture so
  unexpected errors surface clearly in CI (andrewdonheiser)
- Wrap EMBEDDING_DIMENSION int() cast with try/except and pytest.fail
  for a clear error message (tarun-etikala)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address CodeRabbit review feedback

- Use module import for shared fixtures to avoid F811 lint collision
  with fixture argument names
- Move yield outside exception handlers so test assertion failures
  aren't masked as "deployment errors"

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: sort imports to satisfy ruff I001

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: mpk-droid

agents/langgraph/agentic_rag/Makefile

@@ -6,7 +6,7 @@ CONTAINER_CLI  := $(shell command -v podman 2>/dev/null || command -v docker 2>/
 MODEL          ?= llama3.1:8b
 OLLAMA_EMBEDDING_MODEL ?= embeddinggemma:latest
 
-.PHONY: init re-init env ollama llama-server run-app run-app-fresh run-cli load-docs build push build-openshift deploy undeploy test dry-run help
+.PHONY: init re-init env ollama llama-server run-app run-app-fresh run-cli load-docs build push build-openshift deploy undeploy test test-integration dry-run help
 
 help: ## Show this help
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "  %-14s %s\n", $$1, $$2}'
@@ -184,3 +184,8 @@ undeploy: ## Remove deployment from cluster
 
 test: ## Run unit tests
 	uv run --extra dev python -m pytest tests/ --ignore=tests/integration --ignore=tests/behavioral $(PYTEST_ARGS)
+
+test-integration: ## Run integration deployment test
+	PYTHONPATH=$$(git rev-parse --show-toplevel)/tests \
+	  uv run --extra dev python -m pytest tests/integration/test_deployment.py \
+	    -v --tb=long --junitxml=results.xml

agents/langgraph/agentic_rag/tests/integration/__init__.py

@@ -0,0 +1,97 @@
+from __future__ import annotations
+
+import logging
+import os
+
+import integration.conftest  # noqa: F401 — re-exports cluster_auth, repo_root
+import pytest
+from integration.utils import (
+    MakeTargetError,
+    RouteNotFoundError,
+    get_route,
+    load_agent_name,
+    run_make,
+)
+
+logger = logging.getLogger(__name__)
+
+INTERNAL_REGISTRY = "image-registry.openshift-image-registry.svc:5000"
+
+# Optional per agent.yaml but required here to ensure RAG-capable deployment.
+_REQUIRED_ENV = ("BASE_URL", "MODEL_ID", "EMBEDDING_MODEL", "VECTOR_STORE_ID")
+
+
+@pytest.fixture(scope="module")
+def agent_dir(repo_root):
+    return repo_root / "agents" / "langgraph" / "agentic_rag"
+
+
+@pytest.fixture(scope="module")
+def agent_name(agent_dir):
+    return load_agent_name(agent_dir)
+
+
+def _write_env_file(agent_dir, container_image):
+    """Write a .env file with both base and RAG-specific env vars."""
+    missing = [v for v in _REQUIRED_ENV if v not in os.environ]
+    if missing:
+        pytest.fail(
+            f"Missing required env vars for tier-2 RAG agent: {', '.join(missing)}. "
+            "Set them in the CI workflow or export locally."
+        )
+
+    raw_dim = os.environ.get("EMBEDDING_DIMENSION", "768")
+    try:
+        embedding_dim = int(raw_dim)
+    except ValueError:
+        pytest.fail(f"EMBEDDING_DIMENSION must be an integer, got: {raw_dim!r}")
+
+    env_path = agent_dir / ".env"
+    env_path.write_text(
+        f"API_KEY={os.environ.get('API_KEY', 'not-needed')}\n"
+        f"BASE_URL={os.environ['BASE_URL']}\n"
+        f"MODEL_ID={os.environ['MODEL_ID']}\n"
+        f"CONTAINER_IMAGE={container_image}\n"
+        f"EMBEDDING_MODEL={os.environ['EMBEDDING_MODEL']}\n"
+        f"EMBEDDING_DIMENSION={embedding_dim}\n"
+        f"VECTOR_STORE_ID={os.environ['VECTOR_STORE_ID']}\n"
+        f"VECTOR_STORE_PROVIDER={os.environ.get('VECTOR_STORE_PROVIDER', 'milvus')}\n"
+    )
+    return env_path
+
+
+@pytest.fixture(scope="module")
+def deployed_agent(cluster_auth, agent_dir, agent_name):
+    namespace = cluster_auth["namespace"]
+    container_image = f"{INTERNAL_REGISTRY}/{namespace}/{agent_name}:latest"
+    env_path = _write_env_file(agent_dir, container_image)
+
+    deployed = False
+    try:
+        try:
+            logger.info("Building image on cluster via build-openshift...")
+            run_make("build-openshift", cwd=agent_dir, timeout=600)
+
+            logger.info("Deploying to cluster...")
+            run_make("deploy", cwd=agent_dir, timeout=300)
+            deployed = True
+
+            route_url = get_route(agent_name, namespace=namespace)
+            logger.info("Agent deployed at %s", route_url)
+        except (MakeTargetError, RouteNotFoundError) as exc:
+            pytest.fail(f"Deployment failed: {exc}")
+        except Exception as exc:
+            pytest.fail(f"Unexpected error during deployment setup: {exc}")
+
+        yield route_url
+
+    finally:
+        if deployed:
+            logger.info("Tearing down deployment...")
+            try:
+                run_make("undeploy", cwd=agent_dir, timeout=120)
+            except MakeTargetError:
+                logger.warning(
+                    "Cleanup failed — manual undeploy may be needed", exc_info=True
+                )
+        env_path.unlink(missing_ok=True)

agents/langgraph/agentic_rag/tests/integration/conftest.py

@@ -0,0 +1,13 @@
+from __future__ import annotations
+
+import pytest
+from integration.utils import health_check
+
+
+@pytest.mark.integration
+def test_health_endpoint(deployed_agent):
+    route_url = deployed_agent
+    result = health_check(f"{route_url}/health", retries=12, backoff=5.0)
+
+    assert result["status"] == "healthy"
+    assert result["agent_initialized"] is True

agents/langgraph/agentic_rag/tests/integration/test_deployment.py

@@ -25,6 +25,9 @@ def load_agent_name(agent_dir: str | Path) -> str:
     re.compile(r'(apiKey:\s*")[^"]*"'),
     re.compile(r'(--set\s+secrets\.apiKey=")[^"]*"'),
     re.compile(r"(--set\s+secrets\.apiKey=)\S+"),
+    re.compile(r"(VECTOR_STORE_ID=)\S+"),
+    re.compile(r'(--set\s+env\.VECTOR_STORE_ID=")[^"]*"'),
+    re.compile(r"(--set\s+env\.VECTOR_STORE_ID=)\S+"),
 ]