Merge pull request #83 from red-hat-data-services/feat/RHAIENG-4643-langgraph-react-integration-test

feat: add integration test for LangGraph React Agent deployment (RHAIENG-4643)

Author: mpk-droid

.github/actions/setup-cluster/action.yaml

@@ -0,0 +1,38 @@
+name: "Setup Cluster Tools"
+description: "Install Python 3.12, uv, oc, helm, and login to OpenShift. Requires actions/checkout to run first."
+
+inputs:
+  oc-token:
+    description: "OpenShift service account token"
+    required: true
+  cluster-api-url:
+    description: "OpenShift cluster API URL"
+    required: true
+
+runs:
+  using: "composite"
+  steps:
+    - name: Install Python 3.12
+      uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
+      with:
+        python-version: "3.12"
+
+    - name: Install uv
+      uses: astral-sh/setup-uv@6b9c6063abd6010835644d4c2e1bef4cf5cd0fca # v6.0.1
+
+    - name: Install OpenShift CLI and Helm
+      uses: redhat-actions/openshift-tools-installer@144527c7d98999f2652264c048c7a9bd103f8a82 # v1.13.1
+      with:
+        oc: "4"
+        helm: "3"
+
+    - name: Login to OpenShift
+      shell: bash
+      env:
+        OC_TOKEN: ${{ inputs.oc-token }}
+        CLUSTER_API_URL: ${{ inputs.cluster-api-url }}
+      run: |
+        oc login \
+          --token="$OC_TOKEN" \
+          --server="$CLUSTER_API_URL" \
+          --namespace=ci-testing

.github/workflows/agent-deployment-test.yaml

@@ -1,10 +1,9 @@
 # QG4: Agent Deployment Health Checks
 #
-# Foundation workflow: validates that the GitHub Actions runner can connect
-# to the OpenShift cluster. Agent deployment and health checks will be
-# wired up in follow-up tickets.
+# Nightly workflow: logs into the OpenShift demo cluster, deploys each
+# agent via build-openshift + Helm, validates GET /health, and tears down.
 
-name: "QG4: Agent Deployment Health Checks"
+name: "QG4: Agent Deployment Integration Tests"
 
 on:
   schedule:
@@ -17,49 +16,18 @@ permissions:
 jobs:
   verify-cluster-connection:
     name: "Verify Cluster Connection"
+    if: github.repository == 'red-hat-data-services/agentic-starter-kits'
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
       - name: Checkout code
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
-      - name: Install Python 3.12
-        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
+      - name: Setup cluster tools
+        uses: ./.github/actions/setup-cluster
         with:
-          python-version: "3.12"
-
-      - name: Install uv
-        uses: astral-sh/setup-uv@6b9c6063abd6010835644d4c2e1bef4cf5cd0fca # v6.0.1
-
-      - name: Install OpenShift CLI and Helm
-        uses: redhat-actions/openshift-tools-installer@144527c7d98999f2652264c048c7a9bd103f8a82 # v1.13.1
-        with:
-          oc: "4"
-          helm: "3"
-
-      - name: Verify installed tools
-        run: |
-          echo "--- oc ---"
-          oc version --client
-          echo ""
-          echo "--- helm ---"
-          helm version --short
-          echo ""
-          echo "--- python ---"
-          python3 --version
-          echo ""
-          echo "--- uv ---"
-          uv --version
-
-      - name: Login to OpenShift
-        env:
-          OC_TOKEN: ${{ secrets.OC_TOKEN }}
-          CLUSTER_API_URL: ${{ secrets.CLUSTER_API_URL }}
-        run: |
-          oc login \
-            --token="$OC_TOKEN" \
-            --server="$CLUSTER_API_URL" \
-            --namespace=ci-testing
+          oc-token: ${{ secrets.OC_TOKEN }}
+          cluster-api-url: ${{ secrets.CLUSTER_API_URL }}
 
       - name: Verify cluster connection
         run: |
@@ -78,3 +46,43 @@ jobs:
       - name: Logout
         if: always()
         run: oc logout || true
+
+  test-agent:
+    name: "${{ matrix.agent.name }}"
+    needs: verify-cluster-connection
+    if: github.repository == 'red-hat-data-services/agentic-starter-kits'
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    strategy:
+      fail-fast: false
+      matrix:
+        agent:
+          - { name: langgraph-react-agent, dir: agents/langgraph/react_agent }
+    env:
+      API_KEY: ${{ vars.API_KEY }}
+      BASE_URL: ${{ vars.BASE_URL }}
+      MODEL_ID: ${{ vars.MODEL_ID }}
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - name: Setup cluster tools
+        uses: ./.github/actions/setup-cluster
+        with:
+          oc-token: ${{ secrets.OC_TOKEN }}
+          cluster-api-url: ${{ secrets.CLUSTER_API_URL }}
+
+      - name: Run integration test
+        working-directory: ${{ matrix.agent.dir }}
+        run: make test-integration
+
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
+        with:
+          name: ${{ matrix.agent.name }}-results
+          path: ${{ matrix.agent.dir }}/results.xml
+
+      - name: Logout
+        if: always()
+        run: oc logout || true

agents/langgraph/react_agent/Makefile

@@ -5,7 +5,7 @@ VALUES_FILE    := values.yaml
 CONTAINER_CLI  := $(shell command -v podman 2>/dev/null || command -v docker 2>/dev/null)
 MODEL          ?= llama3.1:8b
 
-.PHONY: init re-init env ollama llama-server run-app run-app-fresh run-cli build push build-openshift deploy undeploy test dry-run help
+.PHONY: init re-init env ollama llama-server run-app run-app-fresh run-cli build push build-openshift deploy undeploy test test-integration dry-run help
 
 help: ## Show this help
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "  %-12s %s\n", $$1, $$2}'
@@ -169,4 +169,9 @@ undeploy: ## Remove deployment from cluster
 	helm uninstall $(AGENT_NAME)
 
 test: ## Run tests
-	uv run --extra dev python -m pytest tests/
+	uv run --extra dev python -m pytest tests/ --ignore=tests/integration
+
+test-integration: ## Run integration deployment test
+	PYTHONPATH=$$(git rev-parse --show-toplevel)/tests \
+	  uv run --extra dev python -m pytest tests/integration/test_deployment.py \
+	    -v --tb=long --junitxml=results.xml

agents/langgraph/react_agent/pyproject.toml

@@ -25,6 +25,7 @@ dependencies = [
 [project.optional-dependencies]
 dev = [
     "pytest>=9.0.2",
+    "httpx>=0.27",
 ]
 eval = [
     "unitxt>=1.24.0",

agents/langgraph/react_agent/tests/integration/conftest.py

@@ -0,0 +1,2 @@
+# Re-export shared integration fixtures so pytest discovers them.
+from integration.conftest import cluster_auth, repo_root  # noqa: F401

agents/langgraph/react_agent/tests/integration/test_deployment.py

@@ -0,0 +1,85 @@
+from __future__ import annotations
+
+import logging
+import os
+
+import pytest
+from integration.utils import (
+    MakeTargetError,
+    RouteNotFoundError,
+    get_route,
+    health_check,
+    run_make,
+)
+
+logger = logging.getLogger(__name__)
+
+AGENT_NAME = "langgraph-react-agent"
+INTERNAL_REGISTRY = "image-registry.openshift-image-registry.svc:5000"
+
+
+@pytest.fixture(scope="module")
+def agent_dir(repo_root):
+    return repo_root / "agents" / "langgraph" / "react_agent"
+
+
+def _write_env_file(agent_dir, container_image):
+    """Write a .env file so Makefile targets can source it."""
+    missing = [v for v in ("BASE_URL", "MODEL_ID") if v not in os.environ]
+    if missing:
+        pytest.fail(
+            f"Missing required env vars: {', '.join(missing)}. "
+            "Set them in the CI workflow or export locally."
+        )
+    env_path = agent_dir / ".env"
+    env_path.write_text(
+        f"API_KEY={os.environ.get('API_KEY', 'not-needed')}\n"
+        f"BASE_URL={os.environ['BASE_URL']}\n"
+        f"MODEL_ID={os.environ['MODEL_ID']}\n"
+        f"CONTAINER_IMAGE={container_image}\n"
+    )
+    return env_path
+
+
+@pytest.fixture(scope="module")
+def deployed_agent(cluster_auth, agent_dir):
+    namespace = cluster_auth["namespace"]
+    container_image = f"{INTERNAL_REGISTRY}/{namespace}/{AGENT_NAME}:latest"
+    env_path = _write_env_file(agent_dir, container_image)
+
+    deployed = False
+    try:
+        logger.info("Building image on cluster via build-openshift...")
+        run_make("build-openshift", cwd=agent_dir, timeout=600)
+
+        logger.info("Deploying to cluster...")
+        run_make("deploy", cwd=agent_dir, timeout=300)
+        deployed = True
+
+        route_url = get_route(AGENT_NAME, namespace=namespace)
+        logger.info("Agent deployed at %s", route_url)
+
+        yield route_url
+
+    except (MakeTargetError, RouteNotFoundError) as exc:
+        pytest.fail(f"Deployment failed: {exc}")
+
+    finally:
+        if deployed:
+            logger.info("Tearing down deployment...")
+            try:
+                run_make("undeploy", cwd=agent_dir, timeout=120)
+            except MakeTargetError:
+                logger.warning(
+                    "Cleanup failed — manual undeploy may be needed", exc_info=True
+                )
+        env_path.unlink(missing_ok=True)
+
+
+@pytest.mark.integration
+def test_health_endpoint(deployed_agent):
+    route_url = deployed_agent
+    result = health_check(f"{route_url}/health", retries=12, backoff=5.0)
+
+    assert result["status"] == "healthy"
+    assert result["agent_initialized"] is True

pyproject.toml

@@ -55,7 +55,8 @@ markers = [
     "model_baseline: Model-level tests (prompt injection resistance) - not agent-specific",
     "slow: Tests that run multiple iterations (pass@k, repeated queries)",
     "unit: Fast unit tests for adapter/config packages (no network, no agent required)",
-    "integration: Integration tests for adapter orchestration (mocked HTTP, no live agent)",
+    # --- Integration test suite (agents/*/tests/integration/) ---
+    "integration: Integration tests (adapter orchestration, deployment health checks)",
 ]
 
 [tool.setuptools.packages.find]

tests/integration/__init__.py

@@ -0,0 +1,46 @@
+from __future__ import annotations
+
+import subprocess
+from pathlib import Path
+
+import pytest
+
+
+@pytest.fixture(scope="session")
+def cluster_auth():
+    try:
+        user = subprocess.run(
+            ["oc", "whoami"],
+            capture_output=True,
+            text=True,
+            timeout=15,
+            check=True,
+        ).stdout.strip()
+
+        namespace = subprocess.run(
+            ["oc", "project", "-q"],
+            capture_output=True,
+            text=True,
+            timeout=15,
+            check=True,
+        ).stdout.strip()
+    except (
+        subprocess.CalledProcessError,
+        FileNotFoundError,
+        subprocess.TimeoutExpired,
+    ):
+        pytest.skip("Not logged into an OpenShift cluster")
+
+    if namespace != "ci-testing":
+        pytest.fail(
+            f"Integration tests must run in ci-testing namespace, got: {namespace}"
+        )
+
+    return {"user": user, "namespace": namespace}
+
+
+@pytest.fixture(scope="session")
+def repo_root() -> Path:
+    root = Path(__file__).resolve().parent.parent.parent
+    assert (root / "agents").is_dir(), f"Repo root not found at {root}"
+    return root