Do not Set Metrics when DRPC is being deleted

When the request for DRPC to delete is received, we remove the finalizer
and then delete the metrics. The object is then processed for deletion.
The API server may not delete immediately and it may take some time for
garbage collection to complete the request. Ramen may get the reconcile
call again for which ramen may get the DRPC object which is the deletion
state. At this point in time, we try to set the metrics with zero value
and alerts are being fired. The fix here is that metrics will only be
set if DRPC is not being deleted

Signed-off-by: rakeshgm <[email protected]>
(cherry picked from commit 7d7c492)

Author: rakeshgm

controllers/drplacementcontrol_controller.go

@@ -1668,6 +1668,7 @@ func (r *DRPlacementControlReconciler) getStatusCheckDelay(
 	return time.Until(beforeProcessing.Add(StatusCheckDelay))
 }
 
+//nolint:cyclop
 func (r *DRPlacementControlReconciler) updateDRPCStatus(
 	ctx context.Context, drpc *rmn.DRPlacementControl, userPlacement client.Object, log logr.Logger,
 ) error {
@@ -1683,9 +1684,12 @@ func (r *DRPlacementControlReconciler) updateDRPCStatus(
 		r.updateResourceCondition(drpc, clusterDecision.ClusterName, vrgNamespace, log)
 	}
 
-	if err := r.setDRPCMetrics(ctx, drpc, log); err != nil {
-		// log the error but do not return the error
-		log.Info("failed to set drpc metrics", "errMSg", err)
+	// do not set metrics if DRPC is being deleted
+	if !isBeingDeleted(drpc, userPlacement) {
+		if err := r.setDRPCMetrics(ctx, drpc, log); err != nil {
+			// log the error but do not return the error
+			log.Info("failed to set drpc metrics", "errMSg", err)
+		}
 	}
 
 	for i, condition := range drpc.Status.Conditions {