Skip to content

KFLUXINFRA-3613: Update OWNERS files for infra-owned components#490

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-appstudio:mainfrom
enkeefe00:update-infra-OWNERS-files
Jun 19, 2026
Merged

KFLUXINFRA-3613: Update OWNERS files for infra-owned components#490
openshift-merge-bot[bot] merged 1 commit into
redhat-appstudio:mainfrom
enkeefe00:update-infra-OWNERS-files

Conversation

@enkeefe00

Copy link
Copy Markdown
Collaborator

No description provided.

@enkeefe00 enkeefe00 self-assigned this Jun 18, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

@enkeefe00: This pull request references KFLUXINFRA-3613 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enkeefe00: 8 invalid OWNERS files

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread components/argocd-repo-secrets/OWNERS Outdated
- filariow
- mshaposhnik
- manish-jangra
- @konflux-infra

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 4: found character that cannot start any token.

# See the OWNERS docs: https://go.k8s.io/owners

approvers:
- @konflux-infra

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 4: found character that cannot start any token.

Comment thread components/iam/OWNERS Outdated
- filariow
- mshaposhnik
- manish-jangra
- @konflux-infra

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 4: found character that cannot start any token.

Comment thread components/kueue/OWNERS Outdated
# See the OWNERS docs: https://go.k8s.io/owners

approvers:
- @konflux-infra

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 4: found character that cannot start any token.

Comment thread components/kyverno/OWNERS Outdated
# See the OWNERS docs: https://go.k8s.io/owners

approvers:
- @konflux-infra

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 4: found character that cannot start any token.

Comment thread components/policies/OWNERS Outdated
# See the OWNERS docs: https://go.k8s.io/owners

approvers:
- @konflux-infra

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 4: found character that cannot start any token.

Comment thread components/rover-group-sync/OWNERS Outdated
- filariow
- mshaposhnik
- manish-jangra
- @konflux-infra

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 4: found character that cannot start any token.

Comment thread OWNERS Outdated
- filariow
- mshaposhnik
- manish-jangra
- @konflux-infra

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 7: found character that cannot start any token.

@qodo-for-redhat-appstudio

Copy link
Copy Markdown

PR Summary by Qodo

Standardize infra-owned OWNERS entries to @konflux-infra
⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

Description

• Replace individual approvers/reviewers with the @konflux-infra GitHub team for infra-owned areas.
• Add missing component OWNERS files to establish clear review/approval ownership.
• Simplify root OWNERS to delegate approvals to the infra team alias.
Diagram

graph TD
  PR["PR change"] --> OWN["OWNERS files"] --> PROW["OWNERS plugin"] --> TEAM["@konflux-infra"]
  OWN --> ROOT["repo root"]
  OWN --> CMPS["infra components"]
  subgraph Legend
    direction LR
    _doc["File/Config"] ~~~ _svc["Automation"] ~~~ _team["GitHub team"]
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Add a single parent OWNERS under components/
  • ➕ Reduces duplication across many component directories
  • ➕ Makes future infra-owned additions inherit ownership automatically
  • ➖ May be too broad if some components need different owners
  • ➖ Harder to express exceptions without additional override OWNERS files
2. Keep per-component OWNERS but also add a brief ownership policy doc
  • ➕ Maintains precise ownership boundaries per component
  • ➕ Documents why/when @konflux-infra should be used
  • ➖ Adds a documentation maintenance burden
  • ➖ Doesn’t reduce ongoing OWNERS churn as much as inheritance

Recommendation: Current approach is good if ownership must be explicit per infra-owned component and if other components should not inherit infra ownership. If more infra-owned components are expected soon, consider adding a parent components/ OWNERS (with per-component overrides as needed) to reduce repetitive edits.

Files changed (8) +35 / -42

Other (8) +35 / -42
OWNERSReplace root approvers list with @konflux-infra +1/-6

Replace root approvers list with @konflux-infra

• Removes the explicit list of individual approvers and replaces it with the @konflux-infra team alias at the repository root. This centralizes top-level approval authority to the infra team.

OWNERS

OWNERSDelegate ArgoCD repo secrets ownership to @konflux-infra +2/-12

Delegate ArgoCD repo secrets ownership to @konflux-infra

• Replaces individual approvers and reviewers with the @konflux-infra team. This standardizes ownership for this infra-owned component.

components/argocd-repo-secrets/OWNERS

OWNERSAdd OWNERS for external-secrets-operator under infra ownership +7/-0

Add OWNERS for external-secrets-operator under infra ownership

• Introduces a new OWNERS file defining @konflux-infra as both approver and reviewer. Establishes explicit code ownership for the component.

components/external-secrets-operator/OWNERS

OWNERSDelegate IAM component ownership to @konflux-infra +2/-12

Delegate IAM component ownership to @konflux-infra

• Replaces the existing individual approvers and reviewers with the @konflux-infra team. Aligns IAM ownership with infra-owned conventions.

components/iam/OWNERS

OWNERSAdd OWNERS for kueue under infra ownership +7/-0

Add OWNERS for kueue under infra ownership

• Adds a new OWNERS file setting @konflux-infra as approvers and reviewers. Ensures review routing and approval requirements are owned by infra.

components/kueue/OWNERS

OWNERSAdd OWNERS for kyverno under infra ownership +7/-0

Add OWNERS for kyverno under infra ownership

• Adds a new OWNERS file designating @konflux-infra as approvers and reviewers. Makes ownership explicit for this infra-managed component.

components/kyverno/OWNERS

OWNERSAdd OWNERS for policies under infra ownership +7/-0

Add OWNERS for policies under infra ownership

• Adds a new OWNERS file that assigns approver/reviewer responsibility to @konflux-infra. Clarifies ownership for policy-related content.

components/policies/OWNERS

OWNERSDelegate rover-group-sync ownership to @konflux-infra +2/-12

Delegate rover-group-sync ownership to @konflux-infra

• Replaces the individual approver and reviewer lists with the @konflux-infra team. Standardizes ownership configuration for this component.

components/rover-group-sync/OWNERS

@qodo-for-redhat-appstudio

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Context used
✅ Compliance rules (platform): 5 rules

Grey Divider


Remediation recommended

1. OWNERS uses @-prefix 🐞 Bug ≡ Correctness
Description
The updated OWNERS files list approvers/reviewers as "@konflux-infra", but every other OWNERS file
in this repo uses raw GitHub logins without a leading "@", so this risks OWNERS-based ownership
matching not recognizing the intended owner.
Code

OWNERS[7]

+- @konflux-infra
Relevance

⭐⭐⭐ High

Repo OWNERS files use raw logins; prior OWNERS PRs show no '@'. PR #107 even had invalid-owners-file
enforcement.

PR-#107
PR-#271
PR-#118

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
All existing OWNERS files in this repo list approvers/reviewers as plain identifiers (no leading
@), while @ mention syntax appears in .github/CODEOWNERS. This PR introduces @konflux-infra
into OWNERS, making it inconsistent with established OWNERS formatting and likely to be
misinterpreted by OWNERS tooling expecting raw logins.

OWNERS[3-7]
components/argocd-repo-secrets/OWNERS[3-7]
components/internal-services/OWNERS[3-15]
.github/CODEOWNERS[1-15]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Several `OWNERS` files now use `@konflux-infra` as an approver/reviewer entry. In this repository, `OWNERS` files consistently list *raw* GitHub logins (no leading `@`), while `@user` mention syntax is used in `.github/CODEOWNERS`. Using `@...` in `OWNERS` risks the owner value being treated as a literal string that doesn't match the intended GitHub identity.

## Issue Context
This PR updates multiple OWNERS files to infra ownership and introduces `@konflux-infra` in both `approvers:` and `reviewers:`.

## Fix Focus Areas
- OWNERS[7-7]
- components/argocd-repo-secrets/OWNERS[3-7]
- components/iam/OWNERS[3-7]
- components/rover-group-sync/OWNERS[3-7]
- components/external-secrets-operator/OWNERS[1-7]
- components/kueue/OWNERS[1-7]
- components/kyverno/OWNERS[1-7]
- components/policies/OWNERS[1-7]

## Suggested change
- Replace `- @konflux-infra` with the repo’s standard OWNERS identifier format (e.g., `- konflux-infra` without `@`, or the correct `org/team` string if this is meant to be a GitHub team), consistently across all touched `OWNERS` files.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@enkeefe00 enkeefe00 force-pushed the update-infra-OWNERS-files branch from 7c3fbfa to 5c99ab5 Compare June 18, 2026 18:55

@openshift-ci openshift-ci Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enkeefe00: 8 invalid OWNERS files

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread components/policies/OWNERS Outdated
Comment thread components/rover-group-sync/OWNERS Outdated
Comment thread OWNERS Outdated
Comment thread components/argocd-repo-secrets/OWNERS Outdated
Comment thread components/external-secrets-operator/OWNERS Outdated
Comment thread components/iam/OWNERS Outdated
Comment thread components/kueue/OWNERS Outdated
Comment thread components/kyverno/OWNERS Outdated
@enkeefe00 enkeefe00 force-pushed the update-infra-OWNERS-files branch from 5c99ab5 to d47551a Compare June 18, 2026 18:57

@openshift-ci openshift-ci Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enkeefe00: 8 invalid OWNERS files

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread OWNERS Outdated
Comment thread components/argocd-repo-secrets/OWNERS Outdated
Comment thread components/external-secrets-operator/OWNERS Outdated
Comment thread components/iam/OWNERS Outdated
Comment thread components/kueue/OWNERS Outdated
Comment thread components/kyverno/OWNERS Outdated
Comment thread components/policies/OWNERS Outdated
Comment thread components/rover-group-sync/OWNERS Outdated
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enkeefe00, filariow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 377551f into redhat-appstudio:main Jun 19, 2026
10 checks passed
@enkeefe00 enkeefe00 deleted the update-infra-OWNERS-files branch June 22, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants