fix: When setting a ready by, calculate stop/end date using that time (#2951)

Author: aleixhub

catalog/ui/src/app/Catalog/CatalogItemForm.tsx

@@ -885,15 +885,15 @@ const CatalogItemFormData: React.FC<{ catalogItemName: string; catalogNamespaceN
                             type: 'dates',
                             startDate: provisioningDate, // Internal API still uses provisioning date as startDate
                             stopDate: new Date(
-                              provisioningDate.getTime() +
+                              d.getTime() +
                                 parseDuration(
                                   formState.activity?.startsWith('Customer Facing')
                                     ? '365d'
                                     : catalogItem.spec.runtime?.default || catalogItem.spec.lifespan?.default || '30h'
                                 ),
                             ),
                             endDate: new Date(
-                              provisioningDate.getTime() +
+                              d.getTime() +
                                 parseDuration(
                                   catalogItem.spec.lifespan?.default || '30h'
                                 )

catalog/ui/src/app/Workshops/WorkshopsItem.tsx

@@ -377,6 +377,8 @@ const WorkshopsItemComponent: React.FC<{
       mutateWorkshop(workshopUpdated);
     } else if (modalState.action === 'scheduleReadyByDate') {
       const readyByDate = new Date(date.getTime());
+      // Calculate auto-stop time: 12 hours after the ready-by date
+      const autoStopTime = new Date(readyByDate.getTime() + 12 * 60 * 60 * 1000);
       await startWorkshop(
         workshop,
         !isWorkshopStarted(workshop, workshopProvisions) ? dateToApiString(new Date(date.getTime() + READY_BY_LEAD_TIME_MS)) : null,
@@ -388,7 +390,12 @@ const WorkshopsItemComponent: React.FC<{
       const workshopUpdated = await patchWorkshop({
         name: workshop.metadata.name,
         namespace: workshop.metadata.namespace,
-        patch: { spec: { lifespan: { readyBy: dateToApiString(readyByDate) } } },
+        patch: {
+          spec: {
+            lifespan: { readyBy: dateToApiString(readyByDate) },
+            actionSchedule: { stop: dateToApiString(autoStopTime) },
+          },
+        },
       });
 
       mutateWorkshop(workshopUpdated);