nmstate instance uses deprecated API

[dlbewley]

The nmstate resource here

• https://github.com/redhat-cop/gitops-catalog/blob/main/nmstate/instance/base/nmstate-nmstate.yaml

Has the following issues:

• It uses v1beta1 API which has been deprecated for v1. Observered warning when install to OCP 4.14.
• The spec has a node selector defined, but I'm not sure why. An empty dict should also work.

$ kustomize build 'https://github.com/redhat-cop/gitops-catalog/nmstate/aggregate/overlays/default?ref=main' | kfilt -k nmstate
---
apiVersion: nmstate.io/v1beta1
kind: NMState
metadata:
  annotations:
    argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true
  name: nmstate
spec:
  nodeSelector:
    beta.kubernetes.io/arch: amd64

[strangiato]

Thanks for raising the issue!

I'm seeing references to v1 all the way back to the 4.10 docs so it is probably safe to just update to v1 entirely without having to keep a backwards compatible overlay.

Do you know if there were any important API changes that we need to incorporate between v1beta1 and v1?

Would you be interested in trying out the v1 API on your cluster and updating the objects if everything looks good?