Merge pull request #311 from lorepanichi/fix/rabbitmq-lease-config-invert-guard-condition

raffaelespazzoli · web-flow · commit 8b2385eb35b2 · 2026-04-01T14:35:00.000-04:00
fix: RabbitMQ lease TTL config skipped when values are provided
diff --git a/api/v1alpha1/utils/vaultobject.go b/api/v1alpha1/utils/vaultobject.go
@@ -172,7 +172,7 @@ type RabbitMQEngineConfigVaultEndpoint struct {
 func (ve *RabbitMQEngineConfigVaultEndpoint) CreateOrUpdateLease(context context.Context) error {
 	log := log.FromContext(context)
 	// Skip lease configuration if no values provided
-	if ve.rabbitMQEngineConfigVaultEndpoint.CheckTTLValuesProvided() {
+	if !ve.rabbitMQEngineConfigVaultEndpoint.CheckTTLValuesProvided() {
 		return nil
 	}
 	currentPayload, found, err := read(context, ve.rabbitMQEngineConfigVaultEndpoint.GetLeasePath())

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ type RabbitMQEngineConfigVaultEndpoint struct {`
`172`	`172`	`func (ve *RabbitMQEngineConfigVaultEndpoint) CreateOrUpdateLease(context context.Context) error {`
`173`	`173`	`log := log.FromContext(context)`
`174`	`174`	`// Skip lease configuration if no values provided`
`175`		`- if ve.rabbitMQEngineConfigVaultEndpoint.CheckTTLValuesProvided() {`
	`175`	`+ if !ve.rabbitMQEngineConfigVaultEndpoint.CheckTTLValuesProvided() {`
`176`	`176`	`return nil`
`177`	`177`	`}`
`178`	`178`	`currentPayload, found, err := read(context, ve.rabbitMQEngineConfigVaultEndpoint.GetLeasePath())`