Skip to content

Commit 24ee8a6

Browse files
jackdelahuntdimakisrkpattnaik780
authored
feat: added de-register command (#1812)
* Enterprise crete kafka interactive (#1819) * refactor: moving list enterprise clusters to util package * feat: start of interactive enterprise create * refactor: refactor of create kafka ams checks for enterprise quota (#1822) * feat: when using dedicated with kafka create, we now check the capacity of the cluster * refactor: refactor of the interactive create kafka cmd * refactor: refactoring dedicated list to use refactored search string func * refactor: refactor and addition of name + id of cluster in prompt * refactor: refactor to functional create enterprise flow with some updates based on reviews * Add machine pool logic (#1795) * feat: addition of the new dedicated command to select ocm cluster * feat: addition of getting machine pools and hitting the register cluster endpoint in KFM * refactor: addition of close ocm connection * fix: addition of autoscaling check logic * refactor: addresses commments made in PR * refactor: addresses comments in review * feat: addition of the addon installation flow * feat: addition of cluster-id flag * refactor: addresses some further comments in the review * feat: addition of localization * refactor: addition of error when user has no valid clusters * chore(vendor): update vendoring (#1798) * Add cluster id to create kafka (#1804) * feat: addition of descriptions and examples to dedicated * feat: Allows the CLI to install stage env addons when terraforming customer-cloud dataplane clusters * refactor: the default api url is now set when creating a connection instead of in the registercluster cmd file * refactor: update some func and var names * refactor: add cluster-id flag to create kafka cmd to allow kafka creation on CC cluster * refactor: doc and small refactor * refactor: Refactor ocm methods out of register cmd file (#1807) * feat: addition of descriptions and examples to dedicated * feat: Allows the CLI to install stage env addons when terraforming customer-cloud dataplane clusters * refactor: extraction of clustermgmt funcs from register to own dir * refactor: addresses cluster pagination and refactor of ocm functions * feat: added deregister command * refactor: imrpoved quality of deregister command * chore: added localisation to deregister command * feat: deregister now waits for all kafkas to be deleted * fix: better logging when deleting kafka * refactor: getting cluster list now ask kfm then ocm * chore: remove unused fields * fix: edge case handling in deregister * docs: update the docs (#1826) * refactor: print the httpresponse (#1827) * fix: fixing broken lints * chore: rebase changes --------- Co-authored-by: Dimitri Saridakis <[email protected]> Co-authored-by: Ramakrishna Pattnaik <[email protected]>
1 parent de7a5c6 commit 24ee8a6

File tree

14 files changed

+468
-44
lines changed

14 files changed

+468
-44
lines changed

docs/commands/rhoas.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/commands/rhoas_dedicated.md

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/commands/rhoas_dedicated_deregister-cluster.md

Lines changed: 44 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/commands/rhoas_dedicated_list.md

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/commands/rhoas_dedicated_register-cluster.md

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/cmd/dedicated/dedicated.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package dedicated
22

33
import (
4+
"github.com/redhat-developer/app-services-cli/pkg/cmd/dedicated/deregister"
45
"github.com/redhat-developer/app-services-cli/pkg/cmd/dedicated/listclusters"
56
"github.com/redhat-developer/app-services-cli/pkg/cmd/dedicated/register"
67
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
@@ -18,6 +19,7 @@ func NewDedicatedCmd(f *factory.Factory) *cobra.Command {
1819
cmd.AddCommand(
1920
register.NewRegisterClusterCommand(f),
2021
listclusters.NewListClusterCommand(f),
22+
deregister.NewDeRegisterClusterCommand(f),
2123
)
2224

2325
return cmd

0 commit comments

Comments
 (0)