Skip to content

Commit 5671df5

Browse files
fix(connector create): remove namespace flag (#1793)
BREAKING: namespace flag has been deprecated
1 parent ddd600f commit 5671df5

File tree

3 files changed

+7
-17
lines changed

3 files changed

+7
-17
lines changed

docs/commands/rhoas_connector_update.md

+4-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/cmd/connector/update/update.go

+3-9
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,9 @@ import (
1919
)
2020

2121
type options struct {
22-
namespaceID string
23-
kafkaID string
24-
name string
25-
id string
22+
kafkaID string
23+
name string
24+
id string
2625

2726
outputFormat string
2827
f *factory.Factory
@@ -68,7 +67,6 @@ func NewUpdateCommand(f *factory.Factory) *cobra.Command {
6867
flags := flagutil.NewFlagSet(cmd, f.Localizer)
6968
flags.StringVar(&opts.id, "id", "", f.Localizer.MustLocalize("connector.flag.id.description"))
7069
flags.StringVar(&opts.name, "name", "", f.Localizer.MustLocalize("connector.flag.name.description"))
71-
flags.StringVar(&opts.namespaceID, "namespace-id", "", f.Localizer.MustLocalize("connector.flag.namespaceID.description"))
7270
flags.StringVar(&opts.kafkaID, "kafka-id", "", f.Localizer.MustLocalize("connector.flag.kafkaID.description"))
7371
flags.AddOutput(&opts.outputFormat)
7472

@@ -94,10 +92,6 @@ func runUpdate(opts *options) error {
9492
connector.SetName(opts.name)
9593
connectorChanged = true
9694
}
97-
if opts.namespaceID != "" {
98-
connector.SetNamespaceId(opts.namespaceID)
99-
connectorChanged = true
100-
}
10195
if opts.kafkaID != "" {
10296
kafkaInstance, _, kafkaErr := kafkautil.GetKafkaByID(opts.f.Context, conn.API().KafkaMgmt(), opts.kafkaID)
10397
if kafkaErr != nil {

pkg/core/localize/locales/en/cmd/connectors.toml

-3
Original file line numberDiff line numberDiff line change
@@ -415,9 +415,6 @@ one = 'The location of the configuration file that defines the Connectors instan
415415
[connector.flag.kafka.description]
416416
one = 'ID of the Kafka instance (the default is the Kafka instance for the current context)'
417417

418-
[connector.flag.namespaceID.description]
419-
one = 'ID of the namespace in which you want to deploy the Connectors instance'
420-
421418
[connector.flag.kafkaID.description]
422419
one = 'ID of of the Kafka instance that you want the Connectors instance to use'
423420

0 commit comments

Comments
 (0)