fix: lint error on copying in range loop

jackdelahunt · jackdelahunt · commit f05ef9afbd0c · 2023-02-21T09:31:59.000Z
diff --git a/pkg/cmd/connector/connectorcmdutil/types_util.go b/pkg/cmd/connector/connectorcmdutil/types_util.go
@@ -84,9 +84,9 @@ func FilterValidTypesArgs(f *factory.Factory, toComplete string) ([]string, cobr
 	}
 
 	items := types.GetItems()
-	for _, connector_type := range items {
-		if strings.HasPrefix(connector_type.GetId(), toComplete) {
-			validTypes = append(validTypes, connector_type.GetId())
+	for i := 0; i < len(items); i++ {
+		if strings.HasPrefix(items[i].GetId(), toComplete) {
+			validTypes = append(validTypes, items[i].GetId())
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -84,9 +84,9 @@ func FilterValidTypesArgs(f *factory.Factory, toComplete string) ([]string, cobr`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`items := types.GetItems()`
`87`		`- for _, connector_type := range items {`
`88`		`- if strings.HasPrefix(connector_type.GetId(), toComplete) {`
`89`		`- validTypes = append(validTypes, connector_type.GetId())`
	`87`	`+ for i := 0; i < len(items); i++ {`
	`88`	`+ if strings.HasPrefix(items[i].GetId(), toComplete) {`
	`89`	`+ validTypes = append(validTypes, items[i].GetId())`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`