Skip to content

Commit dc312e5

Browse files
secondsunwtrocki
authored andcommitted
fix: userKafkas Update, removing broken equals impl
1 parent 14d3533 commit dc312e5

File tree

3 files changed

+3
-21
lines changed

3 files changed

+3
-21
lines changed

source/model/src/main/java/com/openshift/cloud/v1alpha/models/UserKafka.java

-15
Original file line numberDiff line numberDiff line change
@@ -89,21 +89,6 @@ public UserKafka setStatus(String status) {
8989
return this;
9090
}
9191

92-
@Override
93-
public boolean equals(Object o) {
94-
if (this == o) return true;
95-
if (o == null || getClass() != o.getClass()) return false;
96-
97-
UserKafka userKafka = (UserKafka) o;
98-
99-
return id.equals(userKafka.id);
100-
}
101-
102-
@Override
103-
public int hashCode() {
104-
return id.hashCode();
105-
}
106-
10792
public String getUpdatedAt() {
10893
return updatedAt;
10994
}

source/rhoas/src/main/java/com/openshift/cloud/beans/AccessTokenSecretTool.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ public String getAccessToken(String accessTokenSecretName, String namespace)
5151
throws ConditionAwareException {
5252
try {
5353
if (isNullOrEmpty(accessTokenSecretName, namespace)) {
54-
throw new IllegalArgumentException("accessTokenSecretName and namespace must be provided and exist.");
54+
throw new IllegalArgumentException(
55+
"accessTokenSecretName and namespace must be provided and exist.");
5556
}
5657
var offlineToken = getOfflineTokenFromSecret(accessTokenSecretName, namespace);
5758
var accessToken = exchangeToken(offlineToken);

source/rhoas/src/main/java/com/openshift/cloud/controllers/CloudServicesRequestController.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,6 @@ void doCreateOrUpdateResource(
6767
userKafkas.add(userKafka);
6868
});
6969

70-
if (userKafkas.equals(resource.getStatus().getUserKafkas())) {
71-
72-
} else {
73-
resource.getStatus().setUserKafkas(userKafkas);
74-
}
70+
resource.getStatus().setUserKafkas(userKafkas);
7571
}
7672
}

0 commit comments

Comments
 (0)