Show LSP diagnostic errors in `Project Errors`

[angelozerr]

Some language servers (ex: our Qute language servers) can report errors for closed document. It would be nice if we could see those erros in the project errors:

vcode provides this feature and can show all errors in the error view and for Qute for instance you can see all errors of all Qute templates (closed and opened):

@ia3andy is it a feature that you would like to have?

I think this feature should be customized per language server definition and we should provide an API to know if LSP diagnostics must be displayed in Project Errors or not.

[acamargo]

Hello @angelozerr , thanks for raising this issue (I was about to create one myself).

Are there any plans to implement this?

A project-wide diagnostics overview would be very beneficial for improving developer awareness.

[angelozerr]

My short plan is to release LSP4IJ 0.12.0 but before we need to fix an annoying freeze issue #899 (reply in thread)

After the release I would like to implement this feature because for our Qute support we will need it //cc @ia3andy to show all errors of Qute template of the project and not only error from opened Qute template (in vscode we have this feature).

Have you some idea how to implement that?

[ericdallo]

@angelozerr makes sense, project aware errors is a must have for any LSP client IMO.
I don't know if lsp4ij register LSP diagnostics using the extension Annotator, because on clojure-lsp before lsp4ij integration, we used to have this for free using that extension

[angelozerr]

LSP4IJ uses an external annotator which register Annotation

lsp4ij/src/main/java/com/redhat/devtools/lsp4ij/features/diagnostics/LSPDiagnosticAnnotator.java

Line 103 in ea0f108

diagnosticSupport.createAnnotation(diagnostic, document, fixes, holder);

Have you some link how you managed that on clojure lsp?

[ericdallo]

@angelozerr here is how we used to do, and here's the definition in plugin.xml

[angelozerr]

That's super strange, because I have the impression that LSP4IJ does the same thing than you?

[angelozerr]

@ericdallo I have created a PR at #936

It doesn't fill the Project Errors but if you click on Inspect Code hyperlink it show the errors of all opened files.

I need to support now the closed file if language server can report diagnostics for closed files (like we have managed with our Qute LS)

[ericdallo]

@angelozerr thanks, although not very helpful for clojure.
clojure-lsp server and multiple servers publish diagnostics of project files even if not opened, that's how it works for years, so it should be possible.

[angelozerr]

@angelozerr thanks, although not very helpful for clojure.

why? because my PR doesn't support closed files? If it that,my goal is to support it because we need that for our Qute LS.

[ericdallo]

Yes, the closed files support is really crucial, thanks!

[angelozerr]

I have implemented closed document diagnostics, Iam testing with our Qute LS.

I have tried to consume lsp clojure but it doesn't publish diagnostics for closed documents?

[ericdallo]

It does @angelozerr if yu have any file with diagnostics, like a unresolved-symbol for example:

(ns some-ns)

fooo ;; unresolved symbol here