fix: call script expand-root-disk.sh conditionally

Commit 394b17e ("fix(rhel): grow disk size to external volume size", Feb 24) introduced a bug. In the cloud-config-base template at line 17, write_files: is unconditional, but all the entries underneath it are conditional. When none of the conditions are true (no ExpandRootDisk, no ActionsRunnerSnippet, no CirrusSnippet, no GitLabSnippet), the generated YAML becomes:

  write_files:

This makes write_files equal to null in YAML, and cloud-init's cc_write_files module crashes with 'NoneType' object is not iterable when it tries to iterate over the entries.

Additionally, the template also unconditionally runs /usr/local/bin/expand-root-disk.sh in runcmd, which would also fail on AWS since the script is never written.

Signed-off-by: Pavol Pitonak <ppitonak@redhat.com>

Author: ppitonak

pkg/target/host/rhel/cloud-config-base

@@ -8,12 +8,13 @@ growpart:
   devices: ["/"]
   ignore_growroot_disabled: false
 runcmd:
-  - /usr/local/bin/expand-root-disk.sh
+{{ if .ExpandRootDisk }}  - /usr/local/bin/expand-root-disk.sh{{ end }}
   - while fuser /var/lib/rpm/.rpm.lock > /dev/null 2>&1 ; do sleep 1 ; done
   - dnf install -y podman
 {{ if .ActionsRunnerSnippet }}  - sudo -u {{ .Username }} bash -c /opt/install-ghrunner.sh{{ end }}
 {{ if .CirrusSnippet }}  - /opt/setup-cirrus-service.sh{{ end }}
 {{ if .GitLabSnippet }}  - sudo -u {{ .Username }} bash -c /opt/install-glrunner.sh{{ end }}
+{{- if or .ExpandRootDisk .ActionsRunnerSnippet .CirrusSnippet .GitLabSnippet }}
 write_files:
 {{- if .ExpandRootDisk }}
   - path: /usr/local/bin/expand-root-disk.sh
@@ -40,3 +41,4 @@ write_files:
     path: /opt/install-glrunner.sh
     permissions: '0755'
 {{ end }}
+{{- end }}