chore: added no logging option for remote commands on compute

previously the remote command on compute would write on std the command being executed remotely, under some circustances we want to prevent this to happen, as example when getting sensitive information from remote as the kubeconfig. Fix #504

Signed-off-by: Adrian Riobo <ariobolo@redhat.com>

Author: adrianriobo

pkg/provider/aws/action/kind/kind.go

@@ -278,14 +278,19 @@ func kubeconfig(ctx *pulumi.Context,
 	// the resulting kubeconfig file can be used to access the cluster
 
 	// Check cluster is ready
-	kindReadyCmd, err := c.RunCommand(ctx, command.CommandCloudInitWait, fmt.Sprintf("%s-kind-readiness", *prefix), awsKindID,
+	kindReadyCmd, err := c.RunCommand(ctx,
+		command.CommandCloudInitWait,
+		compute.LoggingCmdStd,
+		fmt.Sprintf("%s-kind-readiness", *prefix), awsKindID,
 		mk, amiUserDefault, nil, nil)
 	if err != nil {
 		return pulumi.StringOutput{}, err
 	}
 	// Get content for /opt/kubeconfig
 	getKCCmd := ("cat /home/fedora/kubeconfig")
-	getKC, err := c.RunCommand(ctx, getKCCmd,
+	getKC, err := c.RunCommand(ctx,
+		getKCCmd,
+		compute.NoLoggingCmdStd,
 		fmt.Sprintf("%s-kubeconfig", *prefix), awsKindID, mk, amiUserDefault,
 		nil, []pulumi.Resource{kindReadyCmd})
 	if err != nil {

pkg/provider/aws/action/openshift-snc/openshift-snc.go

@@ -389,21 +389,29 @@ func kubeconfig(ctx *pulumi.Context,
 	// the resulting kubeconfig file can be used to access the cluster
 
 	// Check cluster is ready
-	ocpReadyCmd, err := c.RunCommand(ctx, commandReadiness, fmt.Sprintf("%s-ocp-readiness", *prefix), awsOCPSNCID,
+	ocpReadyCmd, err := c.RunCommand(ctx,
+		commandReadiness,
+		compute.LoggingCmdStd,
+		fmt.Sprintf("%s-ocp-readiness", *prefix), awsOCPSNCID,
 		mk, amiUserDefault, nil, nil)
 	if err != nil {
 		return pulumi.StringOutput{}, err
 	}
 	// Check ocp-cluster-ca.service succeeds
-	ocpCaRotatedCmd, err := c.RunCommand(ctx, commandCaServiceRan, fmt.Sprintf("%s-ocp-ca-rotated", *prefix), awsOCPSNCID,
+	ocpCaRotatedCmd, err := c.RunCommand(ctx,
+		commandCaServiceRan,
+		compute.LoggingCmdStd,
+		fmt.Sprintf("%s-ocp-ca-rotated", *prefix), awsOCPSNCID,
 		mk, amiUserDefault, nil, []pulumi.Resource{ocpReadyCmd})
 	if err != nil {
 		return pulumi.StringOutput{}, err
 	}
 
 	// Get content for /opt/kubeconfig
 	getKCCmd := ("cat /opt/kubeconfig")
-	getKC, err := c.RunCommand(ctx, getKCCmd,
+	getKC, err := c.RunCommand(ctx,
+		getKCCmd,
+		compute.NoLoggingCmdStd,
 		fmt.Sprintf("%s-kubeconfig", *prefix), awsOCPSNCID, mk, amiUserDefault,
 		nil, []pulumi.Resource{ocpCaRotatedCmd})
 	if err != nil {

pkg/provider/aws/modules/ec2/compute/compute.go

@@ -26,6 +26,9 @@ const (
 	// Delay health check due to baremetal + userdata otherwise it will kill hosts consntantly
 	// Probably move this to compute asset as each can have different value depending on userdata
 	defaultHealthCheckGracePeriod int = 1200
+
+	LoggingCmdStd   = true
+	NoLoggingCmdStd = false
 )
 
 type ComputeRequest struct {
@@ -245,17 +248,23 @@ func (compute *Compute) Readiness(ctx *pulumi.Context,
 // Check if compute is healthy based on running a remote cmd
 func (compute *Compute) RunCommand(ctx *pulumi.Context,
 	cmd string,
+	loggingCmdStd bool,
 	prefix, id string,
 	mk *tls.PrivateKey, username string,
 	b *bastion.Bastion,
 	dependecies []pulumi.Resource) (*remote.Command, error) {
+	ca := &remote.CommandArgs{
+		Connection: remoteCommandArgs(compute, mk, username, b),
+		Create:     pulumi.String(cmd),
+		Update:     pulumi.String(cmd),
+	}
+	if !loggingCmdStd {
+		ca.Logging = remote.LoggingNone
+	}
 	return remote.NewCommand(ctx,
 		resourcesUtil.GetResourceName(prefix, id, "cmd"),
-		&remote.CommandArgs{
-			Connection: remoteCommandArgs(compute, mk, username, b),
-			Create:     pulumi.String(cmd),
-			Update:     pulumi.String(cmd),
-		}, pulumi.Timeouts(
+		ca,
+		pulumi.Timeouts(
 			&pulumi.CustomTimeouts{
 				Create: command.RemoteTimeout,
 				Update: command.RemoteTimeout}),