Added support for console hostname environment variable

Author: sabre1041

cmd/root.go

@@ -19,9 +19,9 @@ import (
 	"fmt"
 	"os"
 
-	"github.com/spf13/cobra"
-
+	"github.com/redhat-cop/oc-helm/pkg/constants"
 	"github.com/redhat-cop/oc-helm/pkg/options"
+	"github.com/spf13/cobra"
 )
 
 func newRootCmd(commandLineOptions *options.CommandLineOption) (*cobra.Command, error) {
@@ -34,10 +34,10 @@ func newRootCmd(commandLineOptions *options.CommandLineOption) (*cobra.Command,
 		SilenceErrors: true,
 	}
 
-	rootCmd.PersistentFlags().StringVar(&commandLineOptions.ConsoleHostname, "console-hostname", "", "OpenShift Console Hostname")
+	rootCmd.PersistentFlags().StringVar(&commandLineOptions.ConsoleHostname, "console-hostname", os.Getenv(constants.OPENSHIFT_CONSOLE_HOSTNAME_ENV), "OpenShift Console Hostname")
 	rootCmd.PersistentFlags().StringVar(&commandLineOptions.Context, "context", "", "Kubernetes Context")
 	rootCmd.PersistentFlags().StringVarP(&commandLineOptions.Namespace, "namespace", "n", "", "Kubernetes namespace")
-	rootCmd.PersistentFlags().StringVarP(&commandLineOptions.Token, "token", "t", "", "OpenShift OAuth token")
+	rootCmd.PersistentFlags().StringVarP(&commandLineOptions.Token, "token", "t", os.Getenv(constants.OPENSHIFT_OAUTH_TOKEN_ENV), "OpenShift OAuth token")
 
 	rootCmd.AddCommand(
 		newHistoryCmd(commandLineOptions),
@@ -56,7 +56,6 @@ func newRootCmd(commandLineOptions *options.CommandLineOption) (*cobra.Command,
 func Execute() {
 
 	commandLineOption := options.NewCommandLineOption()
-
 	rootCmd, _ := newRootCmd(commandLineOption)
 
 	if err := rootCmd.Execute(); err != nil {

go.sum

@@ -1001,7 +1001,6 @@ k8s.io/component-base v0.20.1/go.mod h1:guxkoJnNoh8LNrbtiQOlyp2Y2XFCZQmrcg2n/DeY
 k8s.io/component-helpers v0.20.1/go.mod h1:Q8trCj1zyLNdeur6pD2QvsF8d/nWVfK71YjN5+qVXy4=
 k8s.io/gengo v0.0.0-20200413195148-3a45101e95ac/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
 k8s.io/gengo v0.0.0-20201113003025-83324d819ded/go.mod h1:FiNAH4ZV3gBg2Kwh89tzAEV2be7d5xI0vBa/VySYy3E=
-k8s.io/helm v1.2.1 h1:Ny4wgW4p7X3tFXR34PziNkUxw2pV0G1DIFmI1QRDdo0=
 k8s.io/helm v2.17.0+incompatible h1:Bpn6o1wKLYqKM3+Osh8e+1/K2g/GsQJ4F4yNF2+deao=
 k8s.io/helm v2.17.0+incompatible/go.mod h1:LZzlS4LQBHfciFOurYBFkCMTaZ0D1l+p0teMg7TSULI=
 k8s.io/klog/v2 v2.0.0/go.mod h1:PBfzABfn139FHAV07az/IF9Wp1bkk3vpT2XSJ76fSDE=

pkg/constants/constants.go

@@ -2,4 +2,6 @@ package constants
 
 const (
 	OPENSHIFT_HELM_INDEX_SEPERATOR = "--"
+	OPENSHIFT_CONSOLE_HOSTNAME_ENV = "OPENSHIFT_CONSOLE_HOSTNAME"
+	OPENSHIFT_OAUTH_TOKEN_ENV      = "OPENSHIFT_OAUTH_TOKEN"
 )