chore: upgrade tasks to node 20

Signed-off-by: lstocchi <[email protected]>

Author: lstocchi

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [ '16', '14', '10' ]
+        node: [ '20', '16' ]
     name: Node ${{ matrix.node }}
 
     steps:
@@ -39,7 +39,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v3
         with:
-          node-version: '10.x'
+          node-version: '20.x'
       - run: npm run setup
       - run: npm install
       - run: npm run build
@@ -53,7 +53,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v3
         with:
-          node-version: '10.x'
+          node-version: '20.x'
       - run: npm run setup
       - run: npm install
       - run: npm run build

package-lock.json

@@ -57,32 +57,32 @@
   },
   "homepage": "https://github.com/redhat-developer/openshift-vsts#readme",
   "dependencies": {
-    "@types/q": "^1.5.1",
-    "@types/valid-url": "^1.0.2",
-    "adm-zip": "^0.4.13",
-    "argv-split": "^2.0.1",
-    "azure-pipelines-task-lib": "^3.1.7",
-    "azure-pipelines-tool-lib": "^1.3.2",
+    "@types/q": "^1.5.8",
+    "@types/valid-url": "^1.0.7",
+    "adm-zip": "^0.5.16",
+    "argv-split": "^3.2.1",
+    "azure-pipelines-task-lib": "^5.0.0",
+    "azure-pipelines-tool-lib": "^2.0.8",
     "decompress": "^4.2.1",
     "decompress-tar": "^4.1.1",
     "decompress-targz": "^4.1.1",
-    "del-cli": "^5.0.0",
-    "node-fetch": "^2.6.7",
+    "del-cli": "^6.0.0",
+    "node-fetch": "^3.3.2",
     "q": "^1.5.1",
-    "semver": "^7.1.3",
+    "semver": "^7.7.1",
     "substituter": "^1.3.0",
     "valid-url": "^1.0.9"
   },
   "devDependencies": {
     "@types/chai": "^4.1.6",
-    "@types/glob": "^7.1.1",
-    "@types/mocha": "^5.2.7",
-    "@types/node": "^12.12.7",
-    "@types/sinon": "^7.0.13",
-    "@types/uuid": "^8.3.0",
+    "@types/glob": "^8.1.0",
+    "@types/mocha": "^10.0.10",
+    "@types/node": "^20.3.1",
+    "@types/sinon": "^17.0.3",
+    "@types/uuid": "^10.0.0",
     "@typescript-eslint/eslint-plugin": "^2.16.0",
     "@typescript-eslint/parser": "^2.16.0",
-    "chai": "^4.2.0",
+    "chai": "4.5.0",
     "chai-fs": "^2.0.0",
     "commit-message-validator": "^0.1.6",
     "copy-node-modules": "^1.0.4",
@@ -91,19 +91,19 @@
     "eslint-config-prettier": "^6.7.0",
     "eslint-import-resolver-typescript": "^2.0.0",
     "eslint-plugin-header": "^3.0.0",
-    "eslint-plugin-import": "2.18.2",
+    "eslint-plugin-import": "2.22.1",
     "eslint-plugin-json": "^2.0.1",
     "eslint-plugin-prettier": "^3.1.1",
     "istanbul": "^0.4.5",
-    "mocha": "^6.0",
+    "mocha": "^7.0",
     "mocha-jenkins-reporter": "^0.4.8",
-    "mocha-junit-reporter": "^1.18.0",
-    "mocha-simple-html-reporter": "^1.1.0",
-    "prettier": "^1.14.3",
+    "mocha-junit-reporter": "^2.2.1",
+    "mocha-simple-html-reporter": "^2.0.0",
+    "prettier": "^3.5.1",
     "remap-istanbul": "^0.13.0",
-    "sinon": "^7.4.2",
-    "ts-mocha": "^6.0",
-    "ts-node": "^7.0.1",
-    "typescript": "^4.0.2"
+    "sinon": "^19.0.2",
+    "ts-mocha": "^10.1.0",
+    "ts-node": "^10.9.2",
+    "typescript": "^5.7.3"
   }
 }

package.json

@@ -68,10 +68,6 @@ export class ConditionHandler {
         return status;
     }
 
-    static async sleep(ms: number):Promise<NodeJS.Timeout> {
-        return new Promise(resolve => setTimeout(resolve, ms));
-    }
-
     static getConditionCommandListener(resource: string): string {
         return `get ${resource} -o name --watch=true`;
     }

src/oc-condition.ts

@@ -13,7 +13,6 @@ import { BinaryVersion, FindBinaryStatus } from './utils/exec_helper';
 
 import tl = require('azure-pipelines-task-lib/task');
 import path = require('path');
-import fetch = require('node-fetch');
 
 export class InstallHandler {
   /**
@@ -268,6 +267,7 @@ export class InstallHandler {
     let url = InstallHandler.ocBundleURL(version.value, osType, false);
     let findURLofLatest = !url;
     if (url) {
+      const { default: fetch } = await import('node-fetch'); // Dynamic import
       // check if url is valid otherwise take the latest stable oc cli for this version
       const response = await fetch(url, { method: 'HEAD' });
       findURLofLatest = !response.ok;

src/oc-install.ts

@@ -25,11 +25,11 @@
     }
   ],
   "version": {
-    "Major": 3,
+    "Major": 4,
     "Minor": 0,
-    "Patch": 2
+    "Patch": 1
   },
-  "minimumAgentVersion": "2.144.0",
+  "minimumAgentVersion": "3.232.1",
   "instanceNameFormat": "config-map $(message)",
   "inputs": [
     {
@@ -151,7 +151,7 @@
     }
   ],
   "execution": {
-    "Node10": {
+    "Node20_1": {
       "target": "lib/config-map-task.js",
       "workingDirectory": "$(currentDirectory)"
     }

tasks/config-map/task.json

@@ -24,11 +24,11 @@
     }
   ],
   "version": {
-    "Major": 3,
+    "Major": 4,
     "Minor": 0,
-    "Patch": 2
+    "Patch": 1
   },
-  "minimumAgentVersion": "2.144.0",
+  "minimumAgentVersion": "3.232.1",
   "instanceNameFormat": "oc-cmd $(message)",
   "inputs": [
     {
@@ -138,7 +138,7 @@
     }
   ],
   "execution": {
-    "Node10": {
+    "Node20_1": {
       "target": "lib/oc-exec-task.js",
       "workingDirectory": "$(currentDirectory)"
     }

tasks/oc-cmd/task.json

@@ -24,11 +24,11 @@
       }
     ],
     "version": {
-      "Major": 3,
+      "Major": 4,
       "Minor": 0,
-      "Patch": 2
+      "Patch": 1
     },
-    "minimumAgentVersion": "2.144.0",
+    "minimumAgentVersion": "3.232.1",
     "instanceNameFormat": "Oc Conditional Cmd",
     "inputs": [
       {
@@ -178,7 +178,7 @@
       }
     ],
     "execution": {
-      "Node10": {
+      "Node20_1": {
         "target": "lib/oc-conditional-exec-task.js",
         "workingDirectory": "$(currentDirectory)"
       }

tasks/oc-conditional-cmd/task.json

@@ -25,11 +25,11 @@
     }
   ],
   "version": {
-    "Major": 3,
+    "Major": 4,
     "Minor": 0,
-    "Patch": 2
+    "Patch": 1
   },
-  "minimumAgentVersion": "2.144.0",
+  "minimumAgentVersion": "3.232.1",
   "instanceNameFormat": "oc-setup $(message)",
   "inputs": [
     {
@@ -112,7 +112,7 @@
     }
   ],
   "execution": {
-    "Node10": {
+    "Node20_1": {
       "target": "lib/oc-setup-task.js",
       "workingDirectory": "$(currentDirectory)"
     }

tasks/oc-setup/task.json

@@ -16,11 +16,9 @@ export function run(): Promise<void> {
   // Create the mocha test
   const mocha = new Mocha({
     ui: 'tdd',
-    useColors: true,
     timeout: 50000,
     slow: 50000
   });
-  mocha.useColors(true);
 
   const testsRoot = path.resolve(__dirname);
 

test/index.debug.ts

@@ -16,7 +16,6 @@ import * as Task from 'azure-pipelines-task-lib/task';
 import path = require('path');
 
 const chai = require('chai');
-chai.use(require('chai-fs'));
 
 const { expect } = chai;