fix: add extension to cached image (#350)

Author: feloy

src/cache.spec.ts

@@ -18,31 +18,55 @@
 
 import { resolve } from 'node:path';
 
+import { env } from '@podman-desktop/api';
 import { vol } from 'memfs';
 import { beforeEach, expect, test, vi } from 'vitest';
 
 import { ImageCache } from './cache';
 
 vi.mock('node:fs');
 vi.mock('node:fs/promises');
+vi.mock('@podman-desktop/api');
 
 beforeEach(() => {
+  vi.resetAllMocks();
   vol.reset();
+  vi.mocked(env).isWindows = false;
+  vi.mocked(env).isMac = false;
+  vi.mocked(env).isLinux = false;
 });
 
-test('images/image and images/rhel9_5 are deleted during init if they exist, rhel9_§ is not deleted', async () => {
+test('images/image and images/rhel9_5 are deleted during init if they exist, rhel9_6 is not deleted, on Windows', async () => {
+  vi.mocked(env).isWindows = true;
   const cachePath = resolve('/', 'path', 'to', 'cache');
   const cache = new ImageCache(cachePath);
   vol.fromJSON({
     '/path/to/cache/images/image': '',
-    '/path/to/cache/images/rhel9_5': '',
-    '/path/to/cache/images/rhel9_6': '',
+    '/path/to/cache/images/rhel9_5.tar.gz': '',
+    '/path/to/cache/images/rhel9_6.tar.gz': '',
   });
 
   await cache.init();
 
   expect(vol.toJSON()).toEqual({
-    '/path/to/cache/images/rhel9_6': '',
+    '/path/to/cache/images/rhel9_6.tar.gz': '',
+  });
+});
+
+test('images/image and images/rhel9_5 are deleted during init if they exist, rhel9_6 is not deleted, on Mac', async () => {
+  vi.mocked(env).isMac = true;
+  const cachePath = resolve('/', 'path', 'to', 'cache');
+  const cache = new ImageCache(cachePath);
+  vol.fromJSON({
+    '/path/to/cache/images/image': '',
+    '/path/to/cache/images/rhel9_5.tar.gz': '',
+    '/path/to/cache/images/rhel9_6.qcow2': '',
+  });
+
+  await cache.init();
+
+  expect(vol.toJSON()).toEqual({
+    '/path/to/cache/images/rhel9_6.qcow2': '',
   });
 });
 
@@ -56,11 +80,28 @@ test('images directory is created', async () => {
   });
 });
 
-test('getPath returns path for known image', async () => {
+test('getPath returns path for known image on Windows', async () => {
+  vi.mocked(env).isWindows = true;
+  const cache = new ImageCache(resolve('/', 'path', 'to', 'cache'));
+  await cache.init();
+  const path = cache.getPath('RHEL 10.0');
+  expect(path).toBe(resolve('/', 'path', 'to', 'cache', 'images', 'rhel10_0.tar.gz'));
+});
+
+test('getPath returns path for known image on Linux', async () => {
+  vi.mocked(env).isMac = true;
+  const cache = new ImageCache(resolve('/', 'path', 'to', 'cache'));
+  await cache.init();
+  const path = cache.getPath('RHEL 10.0');
+  expect(path).toBe(resolve('/', 'path', 'to', 'cache', 'images', 'rhel10_0.qcow2'));
+});
+
+test('getPath returns path for known image on Mac', async () => {
+  vi.mocked(env).isMac = true;
   const cache = new ImageCache(resolve('/', 'path', 'to', 'cache'));
   await cache.init();
   const path = cache.getPath('RHEL 10.0');
-  expect(path).toBe(resolve('/', 'path', 'to', 'cache', 'images', 'rhel10_0'));
+  expect(path).toBe(resolve('/', 'path', 'to', 'cache', 'images', 'rhel10_0.qcow2'));
 });
 
 test('getPath raises an exception for an unknown image', async () => {

src/cache.ts

@@ -19,14 +19,18 @@
 import { mkdir, readdir, rm } from 'node:fs/promises';
 import { resolve } from 'node:path';
 
+import { env } from '@podman-desktop/api';
+
 import { RHEL_VMS_IMAGE_PROPERTY_VALUE_RHEL_9, RHEL_VMS_IMAGE_PROPERTY_VALUE_RHEL_10 } from './constants';
 
 export class ImageCache {
   #cachedImageDir: string;
 
+  #extension = env.isWindows ? '.tar.gz' : '.qcow2';
+
   #cachedImageNames: Record<string, string> = {
-    [RHEL_VMS_IMAGE_PROPERTY_VALUE_RHEL_10]: 'rhel10_0',
-    [RHEL_VMS_IMAGE_PROPERTY_VALUE_RHEL_9]: 'rhel9_6',
+    [RHEL_VMS_IMAGE_PROPERTY_VALUE_RHEL_10]: `rhel10_0${this.#extension}`,
+    [RHEL_VMS_IMAGE_PROPERTY_VALUE_RHEL_9]: `rhel9_6${this.#extension}`,
   };
 
   constructor(storagePath: string) {