Skip to content

Commit 661049e

Browse files
authored
chore: add pnpm version to package.json (#390)
* chore: add pnpm version to package.json Signed-off-by: Philippe Martin <phmartin@redhat.com> * fix: remove pnpm version from workflow Signed-off-by: Philippe Martin <phmartin@redhat.com> * chore: extract pnpm version from packageManager for builder image --------- Signed-off-by: Philippe Martin <phmartin@redhat.com>
1 parent 2610572 commit 661049e

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/pr-check.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ jobs:
3333
- uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
3434
name: Install pnpm
3535
with:
36-
version: 10
3736
run_install: false
3837

3938
- uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0
@@ -62,7 +61,6 @@ jobs:
6261
- uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
6362
name: Install pnpm
6463
with:
65-
version: 10
6664
run_install: false
6765

6866
- uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0
@@ -92,7 +90,6 @@ jobs:
9290
- uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
9391
name: Install pnpm
9492
with:
95-
version: 10
9693
run_install: false
9794

9895
- uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0

build/Containerfile.builder

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,7 @@ COPY tests/playwright/package.json tests/playwright/package.json
2929
COPY .npmrc .npmrc
3030

3131
RUN npm i -g ssh2@1.16.0 && \
32-
npm install --global pnpm@10.20.0 && \
32+
PNPM_VERSION=$(cat package.json | jq .packageManager | sed -E 's|.*pnpm@([0-9.]+).*|\1|') && \
33+
echo Installing pnpm version ${PNPM_VERSION} && \
34+
npm install --global pnpm@${PNPM_VERSION} && \
3335
pnpm --frozen-lockfile install

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,5 +143,6 @@
143143
"typescript-eslint": "^8.49.0",
144144
"vite": "^7.2.7",
145145
"vitest": "^4"
146-
}
146+
},
147+
"packageManager": "pnpm@10.20.0+sha512.cf9998222162dd85864d0a8102e7892e7ba4ceadebbf5a31f9c2fce48dfce317a9c53b9f6464d1ef9042cba2e02ae02a9f7c143a2b438cd93c91840f0192b9dd"
147148
}

0 commit comments

Comments
 (0)