Skip to content

RHIDP-5515: Document default PVC and Secret configuration update #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jmagak
Copy link
Member

@jmagak jmagak commented Apr 9, 2025

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): main, 1.5

Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5515

Related PR with both Peer and Technical Reviews, Comments and Suggestions: PR-1024

Preview link: 9. Configuring default mounts for Secrets and PVCs

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Apr 9, 2025

@jmagak jmagak added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Apr 11, 2025
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments / suggestions

@jmagak jmagak force-pushed the RHIDP-5515-document-default-PVC-and-Secret-Configuration-2 branch from 21b6c6d to 53aa2f1 Compare April 16, 2025 11:08
@jmagak jmagak requested a review from linfraze April 16, 2025 11:42
[id="assembly-configuring-default-secret-pvc-mounts_{context}"]
= Configuring default mounts for Secrets and PVCs

You can configure Persistent Volume Claims (PVCs) and Secrets mount in your {product} deployment. Use annotations to define the custom mount paths and specify the containers to mount them to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised redhat-documentation/vale-at-red-hat#932 to fix the following Vale alert:

[vale] reported by reviewdog 🐶
[RedHat.Spelling] Verify the word 'PVCs'. It is not in the American English spelling dictionary used by Vale.

Raw Output:
{"message": "[RedHat.Spelling] Verify the word 'PVCs'. It is not in the American English spelling dictionary used by Vale.", "location": {"path": "assemblies/assembly-configuring-default-secret-pvc-mounts.adoc", "range": {"start": {"line": 5, "column": 45}}}, "severity": "WARNING"}

@jmagak jmagak force-pushed the RHIDP-5515-document-default-PVC-and-Secret-Configuration-2 branch from bbb5d26 to e630d46 Compare April 23, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants