Skip to content

RHIDP-6566: Rename Create with Self-service #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

@rhdh-bot
Copy link
Collaborator

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hmanwani-rh. Lgtm!

Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacements look good; just a couple suggestions

Comment on lines +24 to +25
. Browse the list of groups shown on the page.
. Select a group to view the information imported from Keycloak.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can combine these into a single step or maybe replace with something like the following:

Suggested change
. Browse the list of groups shown on the page.
. Select a group to view the information imported from Keycloak.
. From the list of groups, select a group to view the information imported from Keycloak.


image::rhdh-plugins-reference/group1.jpg[group-profile]
.Procedure
. Go to the *Catalog* page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be helpful to orient the user so they know where to start. From where do they go to the Catalog page? Do we mean something like From the {product} home page or In the {product} navigation menu, click Catalog?

@@ -6,7 +6,7 @@
As an administrator, you can configure the {product} global header to create a consistent and flexible navigation bar across your {product-short} instance.
By default, the {product-short} global header includes the following components:

* *Create* button provides quick access to a variety of templates, enabling users to efficiently set up services, backend and front-end plugins within {product-short}
* *Self-service* button provides quick access to a variety of templates, enabling users to efficiently set up services, backend and front-end plugins within {product-short}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to Self-service looks good but wondering if we should use back end or back-end. IBM says to only use backend when referring to a specific product or thing in Python.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect we have a glossar, but my opinion on this is: frontend and backend, no space, no dash.

@@ -2,7 +2,7 @@
= Customizing your {product} global header

You can use the `red-hat-developer-hub.backstage-plugin-global-header` dynamic plugin to extend the global header with additional buttons and customize the order and position of icons and features. Additionally, you can create and integrate your custom dynamic header plugins using the mount points provided by this new header feature, allowing you to further tailor to suit your needs.
For more information on enabling dynamic plugins, see link:{installing-and-viewing-dynamic-plugins-url}[{installing-and-viewing-dynamic-plugins-title}].
For more information on enabling dynamic plugins, see link:{installing-and-viewing-plugins-book-url}[{installing-and-viewing-plugins-book-title}].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information on enabling dynamic plugins, see link:{installing-and-viewing-plugins-book-url}[{installing-and-viewing-plugins-book-title}].
For more information about enabling dynamic plugins, see link:{installing-and-viewing-plugins-book-url}[{installing-and-viewing-plugins-book-title}].

I recall one of the style guides saying to use about in place of on in this context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants