fix: Fix hardcoded image for test connection pod and allow to skip the creation of this pod [RHDHBUGS-155] [RHIDP-5558] #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR makes the test-connection pod image configurable.
As reported in https://issues.redhat.com/browse/RHDHBUGS-155, the fact that the image is hardcoded can be an issue in air-gapped environments.
Besides that, this PR also makes it possible to disable the creation of this test-connection pod. I've tested it and it doesn't prevent
helm test
from passing even with no test pod available.Existing or Associated Issue(s)
Additional Information
helm test
$ helm upgrade --install my-backstage-1 charts/backstage --set route.enabled=false --set test.enabled=false $ helm test my-backstage-1 [...] NAME: my-backstage-1 LAST DEPLOYED: Tue Jan 14 18:28:25 2025 NAMESPACE: my-ns STATUS: deployed REVISION: 1 TEST SUITE: None
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -a
to apply changes.pre-commit
hook.ct lint
command.