fix(bulk-import): prevent approval tool resetting to GitHub on link clicks (#3364)

Add e.preventDefault() to Link onClick handlers that use to="" to stop
React Router from navigating and stripping the approvalTool query
parameter from the URL, which caused the form to reinitialize with
GitHub as the default.

Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3345

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

Author: its-mitesh-kumar

workspaces/bulk-import/.changeset/gentle-foxes-leap.md

@@ -0,0 +1,5 @@
+---
+'@red-hat-developer-hub/backstage-plugin-bulk-import': patch
+---
+
+Fixed approval tool selection resetting to GitHub when clicking Preview file by preventing unintended router navigation that stripped the approvalTool query parameter from the URL.

workspaces/bulk-import/plugins/bulk-import/src/components/AddRepositories/SelectRepositories.tsx

@@ -52,7 +52,13 @@ export const SelectRepositories = ({
         data-testid="no-repositories"
       >
         {t('addRepositories.allRepositoriesAdded')}{' '}
-        <Link to="" onClick={() => onOrgRowSelected(orgData)}>
+        <Link
+          to=""
+          onClick={e => {
+            e.preventDefault();
+            onOrgRowSelected(orgData);
+          }}
+        >
           {t('common.view')}
         </Link>
       </Typography>
@@ -66,7 +72,13 @@ export const SelectRepositories = ({
     return (
       <Typography component="span" data-testid="select-repositories">
         {t('addRepositories.noSelection')}{' '}
-        <Link to="" onClick={() => onOrgRowSelected(orgData)}>
+        <Link
+          to=""
+          onClick={e => {
+            e.preventDefault();
+            onOrgRowSelected(orgData);
+          }}
+        >
           {t('common.select')}
         </Link>
       </Typography>
@@ -76,7 +88,13 @@ export const SelectRepositories = ({
     <Typography component="span" data-testid="edit-repositories">
       {Object.keys(orgData.selectedRepositories || [])?.length}/
       {(orgData?.totalReposInOrg || 0) - addedRepositoriesCount}{' '}
-      <Link onClick={() => onOrgRowSelected(orgData)} to="">
+      <Link
+        to=""
+        onClick={e => {
+          e.preventDefault();
+          onOrgRowSelected(orgData);
+        }}
+      >
         {t('common.edit')}
       </Link>
     </Typography>

workspaces/bulk-import/plugins/bulk-import/src/components/PreviewFile/PreviewFile.tsx

@@ -80,9 +80,12 @@ export const PreviewFile = ({ data }: { data: AddRepositoryData }) => {
 
           <Link
             to={errorMessage.showRepositoryLink ? data.repoUrl || '' : ''}
-            onClick={() =>
-              errorMessage.showRepositoryLink ? null : openDrawer(data)
-            }
+            onClick={e => {
+              if (!errorMessage.showRepositoryLink) {
+                e.preventDefault();
+                openDrawer(data);
+              }
+            }}
             data-testid="edit-pull-request"
           >
             {errorMessage.showRepositoryLink ? (
@@ -107,7 +110,10 @@ export const PreviewFile = ({ data }: { data: AddRepositoryData }) => {
           <Link
             to=""
             style={{ marginLeft: '4px' }}
-            onClick={() => openDrawer(data)}
+            onClick={e => {
+              e.preventDefault();
+              openDrawer(data);
+            }}
             data-testid={
               Object.keys(data?.selectedRepositories || []).length > 1
                 ? 'preview-files'

workspaces/bulk-import/plugins/bulk-import/src/components/PreviewFile/PreviewFileSidebarDrawerContent.tsx

@@ -201,7 +201,14 @@ export const PreviewFileSidebarDrawerContent = ({
         >
           {t('common.save')}
         </Button>
-        <Link to="" variant="button" onClick={onCancel}>
+        <Link
+          to=""
+          variant="button"
+          onClick={e => {
+            e.preventDefault();
+            onCancel();
+          }}
+        >
           <Button variant="outlined">{t('common.cancel')}</Button>
         </Link>
       </Box>