fix(e2e): improve dialog handler for Node 24 compatibility

- Add proper cleanup of dialog event listener to prevent memory leaks
- Use try-finally pattern to ensure cleanup happens
- Fixes Node 24 E2E test failures while maintaining Node 22 compatibility

Author: Eswaraiahsapram

workspaces/scorecard/packages/app-legacy/e2e-tests/pages/CatalogPage.ts

@@ -37,18 +37,25 @@ export class CatalogPage {
   }
 
   async loginAndSetLocale(locale: string) {
-    this.page.on('dialog', dialog => dialog.accept());
+    // Set up dialog handler before any page navigation to catch potential dialogs
+    const dialogHandler = (dialog: any) => dialog.accept();
+    this.page.on('dialog', dialogHandler);
 
-    await this.page.goto('/');
-    const enterButton = this.page.getByRole('button', { name: 'Enter' });
-    await expect(enterButton).toBeVisible({ timeout: 30000 });
-    await enterButton.click();
-    await expect(
-      this.page.getByRole('link', { name: 'Home' }).first(),
-    ).toBeVisible({
-      timeout: 30000,
-    });
-    await this.switchToLocale(locale);
+    try {
+      await this.page.goto('/');
+      const enterButton = this.page.getByRole('button', { name: 'Enter' });
+      await expect(enterButton).toBeVisible({ timeout: 30000 });
+      await enterButton.click();
+      await expect(
+        this.page.getByRole('link', { name: 'Home' }).first(),
+      ).toBeVisible({
+        timeout: 30000,
+      });
+      await this.switchToLocale(locale);
+    } finally {
+      // Clean up the event listener to prevent memory leaks
+      this.page.off('dialog', dialogHandler);
+    }
   }
 
   async openCatalog() {