refactor(scorecard): rename aggregation KPI from avgKpi to weightedKpi across tests and configurations

Signed-off-by: Ihor Mykhno <imykhno@redhat.com>

Author: imykhno

workspaces/scorecard/plugins/scorecard-backend/src/service/aggregations/AggregationsService.test.ts

@@ -113,7 +113,7 @@ describe('AggregationsService', () => {
       entityRefs: ['component:default/a'],
       thresholds,
       aggregationConfig: {
-        id: 'avgKpi',
+        id: 'weightedKpi',
         title: 'Weighted health KPI',
         description: 'Weighted health score across statuses',
         metricId: metric.id,

workspaces/scorecard/plugins/scorecard-backend/src/service/aggregations/strategies/weightedStatusScoreAggregationStrategy.test.ts

@@ -56,7 +56,7 @@ describe('WeightedStatusScoreAggregationStrategy', () => {
     const logger = mockServices.logger.mock();
     const strategy = new WeightedStatusScoreAggregationStrategy(loader, logger);
     const aggregationConfig = {
-      id: 'avgKpi',
+      id: 'weightedKpi',
       metricId: metric.id,
       type: aggregationTypes.weightedStatusScore,
       options: {
@@ -108,7 +108,7 @@ describe('WeightedStatusScoreAggregationStrategy', () => {
       entityRefs: ['component:default/a'],
       thresholds,
       aggregationConfig: {
-        id: 'avgKpi',
+        id: 'weightedKpi',
         metricId: metric.id,
         type: aggregationTypes.weightedStatusScore,
         options: {
@@ -149,7 +149,7 @@ describe('WeightedStatusScoreAggregationStrategy', () => {
         entityRefs: ['component:default/a'],
         thresholds,
         aggregationConfig: {
-          id: 'avgKpi',
+          id: 'weightedKpi',
           metricId: metric.id,
           type: aggregationTypes.weightedStatusScore,
         } as any,
@@ -176,7 +176,7 @@ describe('WeightedStatusScoreAggregationStrategy', () => {
     const strategy = new WeightedStatusScoreAggregationStrategy(loader, logger);
 
     const aggregationConfig = {
-      id: 'avgKpi',
+      id: 'weightedKpi',
       metricId: metric.id,
       type: aggregationTypes.weightedStatusScore,
       options: {

workspaces/scorecard/plugins/scorecard-backend/src/service/router.test.ts

@@ -1191,7 +1191,7 @@ describe('createRouter', () => {
       const kpiConfig = new ConfigReader({
         scorecard: {
           aggregationKPIs: {
-            avgKpi: {
+            weightedKpi: {
               title: 'Weighted health KPI',
               description: 'Weighted status score',
               type: 'weightedStatusScore',
@@ -1245,7 +1245,7 @@ describe('createRouter', () => {
       kpiApp.use(router);
       kpiApp.use(mockErrorHandler());
 
-      await request(kpiApp).get('/aggregations/avgKpi');
+      await request(kpiApp).get('/aggregations/weightedKpi');
 
       expect(getSpy).toHaveBeenCalledWith(
         ['component:default/my-service', 'component:default/my-other-service'],

workspaces/scorecard/plugins/scorecard-backend/src/utils/buildAggregationConfig.test.ts

@@ -53,10 +53,10 @@ describe('buildAggregationConfig', () => {
       },
     });
 
-    const result = buildAggregationConfig('avgKpi', { config });
+    const result = buildAggregationConfig('weightedKpi', { config });
 
     expect(result).toEqual({
-      id: 'avgKpi',
+      id: 'weightedKpi',
       title: 'Weighted health',
       description: 'Weighted health score across statuses',
       type: aggregationTypes.weightedStatusScore,
@@ -86,7 +86,7 @@ describe('buildAggregationConfig', () => {
       },
     });
 
-    const result = buildAggregationConfig('avgKpi', { config });
+    const result = buildAggregationConfig('weightedKpi', { config });
 
     expect(result.options?.thresholds?.rules).toEqual([
       { key: 'success', expression: '>=75', color: 'success.main' },

workspaces/scorecard/plugins/scorecard-backend/src/validation/validateAggregationConfig.test.ts

@@ -158,7 +158,7 @@ describe('validateAggregationConfig', () => {
     const rootConfig = new ConfigReader({
       scorecard: {
         aggregationKPIs: {
-          avgKpi: {
+          weightedKpi: {
             title: 'Avg KPI',
             type: aggregationTypes.weightedStatusScore,
             description: 'Weighted health score',
@@ -180,7 +180,7 @@ describe('validateAggregationConfig', () => {
     const rootConfig = new ConfigReader({
       scorecard: {
         aggregationKPIs: {
-          avgKpi: {
+          weightedKpi: {
             title: 'Avg KPI',
             type: aggregationTypes.weightedStatusScore,
             description: 'Weighted health score',
@@ -203,7 +203,7 @@ describe('validateAggregationConfig', () => {
     const rootConfig = new ConfigReader({
       scorecard: {
         aggregationKPIs: {
-          avgKpi: {
+          weightedKpi: {
             title: 'Avg KPI',
             type: aggregationTypes.weightedStatusScore,
             description: 'Weighted health score',
@@ -243,7 +243,7 @@ describe('validateAggregationConfig', () => {
     const rootConfig = new ConfigReader({
       scorecard: {
         aggregationKPIs: {
-          avgKpi: {
+          weightedKpi: {
             title: 'Avg KPI',
             type: aggregationTypes.weightedStatusScore,
             description: 'Weighted health score',
@@ -277,7 +277,7 @@ describe('validateAggregationConfig', () => {
     const rootConfig = new ConfigReader({
       scorecard: {
         aggregationKPIs: {
-          avgKpi: {
+          weightedKpi: {
             title: 'Avg KPI',
             type: aggregationTypes.weightedStatusScore,
             description: 'Weighted health score',