Skip to content

Commit 6fca659

Browse files
committed
fix(lightspeed): minor UI fix
Signed-off-by: Yi Cai <yicai@redhat.com>
1 parent da7b3bc commit 6fca659

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@red-hat-developer-hub/backstage-plugin-lightspeed': patch
3+
---
4+
5+
Fix duplicate caret icons in the message bar model selector dropdown.

workspaces/lightspeed/plugins/lightspeed/src/components/MessageBarModelSelector.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import {
2424
MenuToggle,
2525
MenuToggleElement,
2626
} from '@patternfly/react-core';
27-
import { AngleDownIcon } from '@patternfly/react-icons';
2827

2928
import { useTranslation } from '../hooks/useTranslation';
3029

@@ -37,9 +36,6 @@ type MessageBarModelSelectorProps = {
3736

3837
const useStyles = makeStyles(theme => ({
3938
selectorToggle: {
40-
display: 'flex',
41-
alignItems: 'center',
42-
gap: 4,
4339
color: theme.palette.text.secondary,
4440
fontSize: 14,
4541
fontWeight: 500,
@@ -55,6 +51,11 @@ const useStyles = makeStyles(theme => ({
5551
cursor: 'not-allowed',
5652
opacity: 0.5,
5753
},
54+
// PF v6 dual-mapped icons render default + rh-ui SVGs; hide rh-ui so only
55+
// one caret shows (matches prototype toggle-icon structure).
56+
'& .pf-v6-c-menu-toggle__toggle-icon .pf-v6-icon-rh-ui': {
57+
display: 'none',
58+
},
5859
},
5960
dropdown: {
6061
'& ul, & li': {
@@ -83,12 +84,11 @@ export const MessageBarModelSelector = ({
8384
onClick={() => setIsOpen(!isOpen)}
8485
isExpanded={isOpen}
8586
isDisabled={disabled}
86-
variant="plain"
87+
variant="plainText"
8788
className={classes.selectorToggle}
8889
aria-label={t('aria.chatbotSelector')}
8990
>
9091
{selectedModelLabel}
91-
<AngleDownIcon />
9292
</MenuToggle>
9393
);
9494

0 commit comments

Comments
 (0)