Skip to content

Commit 727c4de

Browse files
committed
address review comments
1 parent 42a0791 commit 727c4de

18 files changed

Lines changed: 62 additions & 35 deletions

File tree

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
---
22
'@red-hat-developer-hub/backstage-plugin-boost': patch
3+
'@red-hat-developer-hub/backstage-plugin-boost-backend': patch
4+
'@red-hat-developer-hub/backstage-plugin-boost-backend-module-kagenti': patch
5+
'@red-hat-developer-hub/backstage-plugin-boost-backend-module-llamastack': patch
6+
'@red-hat-developer-hub/backstage-plugin-boost-common': patch
7+
'@red-hat-developer-hub/backstage-plugin-boost-node': patch
8+
'@red-hat-developer-hub/backstage-plugin-boost-responses-api-toolkit': patch
9+
'@red-hat-developer-hub/backstage-plugin-boost-toolscope': patch
310
---
411

5-
Add the Boost New Frontend System plugin with a lazy-loaded `/ai-catalog` route and AI Catalog scaffold page for local development.
12+
Add the Boost New Frontend System plugin with a lazy-loaded `/ai-catalog` route and AI Catalog scaffold page for local development. Register the frontend plugin in boost plugin family metadata (`pluginPackages`).

workspaces/boost/app-config.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ organization:
1717
backend:
1818
# Used for enabling authentication, secret is shared by all backend plugins
1919
# See https://backstage.io/docs/auth/service-to-service-auth for
20-
# information on the format
20+
# information on the format.
21+
# Enable backend.auth.keys before any non-local deployment.
2122
# auth:
2223
# keys:
2324
# - secret: ${BACKEND_SECRET}
@@ -79,6 +80,8 @@ techdocs:
7980

8081
auth:
8182
# see https://backstage.io/docs/auth/ to learn about auth providers
83+
# Local dev only: guest provider with auto sign-in (see packages/app sign-in module).
84+
# Do not use this configuration in production deployments.
8285
environment: development
8386
providers:
8487
# See https://backstage.io/docs/auth/guest/provider

workspaces/boost/openspec/changes/ai-chat-interaction-experience/proposal.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Boost builds the frontend as composable extensions from the start — chat, admi
4444

4545
## Impact
4646

47-
- `plugins/boost-frontend/src/plugin.ts` — composable routable extensions
48-
- `plugins/boost-frontend/src/components/ChatView.tsx` — lazy loading, capability checks
49-
- `plugins/boost-frontend/src/components/AdminLayout.tsx` — lazy loading per panel group
47+
- `plugins/boost/src/plugin.ts` — composable routable extensions
48+
- `plugins/boost/src/components/ChatView.tsx` — lazy loading, capability checks
49+
- `plugins/boost/src/components/AdminLayout.tsx` — lazy loading per panel group
5050
- `plugins/boost-common/src/config.d.ts` — feature flags schema

workspaces/boost/openspec/changes/platform-operations-deployment/proposal.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@ Boost ships as a set of modular RHDH dynamic plugins (OCI) and Backstage static
1414

1515
| Package | Purpose |
1616
| --------------------------------- | ----------------------------------------------------------------- |
17-
| `boost-frontend` | Chat UI, agent gallery, admin panels, composable extensions |
17+
| `boost` | Chat UI, agent gallery, admin panels, composable extensions |
1818
| `boost-common` | Shared types, permissions (browser-safe, `common-library` role) |
1919
| `boost-node` | Service refs, extension points (`node-library` role) |
20+
| `boost-responses-api-toolkit` | Shared Responses API utilities (`node-library` role) |
21+
| `boost-toolscope` | Injectable cache adapter for tool scope (`node-library` role) |
2022
| `boost-backend` | Core routes, services, middleware, cross-cutting entity providers |
2123
| `boost-backend-module-llamastack` | Llama Stack agentic provider |
2224
| `boost-backend-module-kagenti` | Kagenti agentic provider |
@@ -72,4 +74,4 @@ These principles are informed by the Augment reference prototype's experience (s
7274
- `plugins/boost-backend/src/services/` — RuntimeConfigResolver, config validation, cache management
7375
- `plugins/boost-backend/src/routes/` — admin panel API routes
7476
- `plugins/boost-common/src/config.d.ts` — generated from Zod schemas
75-
- `plugins/boost-frontend/src/admin/` — admin panel components, feature flag integration
77+
- `plugins/boost/src/admin/` — admin panel components, feature flag integration

workspaces/boost/openspec/changes/pluggable-ai-platform-architecture/design.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ boost-common (common-library) ←── boost-node (node-library) ←──
5454
│ boost-backend-module-llamastack
5555
│ boost-backend-module-kagenti
5656
57-
boost-frontend (imports types only)
57+
boost (imports types only)
5858
```
5959

6060
`boost-common` exports: `AgenticProvider`, `ProviderDescriptor`, `ProviderCapabilities`, `NormalizedStreamEvent`, conversation types, permission definitions.

workspaces/boost/openspec/changes/pluggable-ai-platform-architecture/proposal.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,4 @@ Two built-in provider modules, each as an independent `createBackendModule`:
5151
- `plugins/boost-backend/src/plugin.ts` — serviceRef factory registration, ProviderManager
5252
- `plugins/boost-backend-module-llamastack/` — Llama Stack provider module
5353
- `plugins/boost-backend-module-kagenti/` — Kagenti provider module
54-
- `plugins/boost-frontend/src/` — capability-based rendering throughout
54+
- `plugins/boost/src/` — capability-based rendering throughout

workspaces/boost/openspec/changes/security-safety-governance/proposal.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,5 @@ Enterprise AI platforms must treat security, safety, and governance as foundatio
4444

4545
- `plugins/boost-common/src/permissions.ts` — 16 permission definitions with resource types
4646
- `plugins/boost-backend/src/middleware/security.ts``authorizeLifecycleAction` middleware
47-
- `plugins/boost-frontend/src/components/SecurityGate.tsx` — granular permission checks
47+
- `plugins/boost/src/components/SecurityGate.tsx` — granular permission checks
4848
- `plugins/boost-backend/src/services/TokenExchangeManager.ts` — RFC 8693 implementation

workspaces/boost/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"start": "backstage-cli repo start",
1111
"start:debug": "backstage-cli repo start --inspect",
1212
"build:all": "backstage-cli repo build --all",
13-
"build:api-reports": "yarn tsc:full; yarn build:api-reports:only",
13+
"build:api-reports": "yarn tsc:full && yarn build:api-reports:only",
1414
"build:api-reports:only": "backstage-repo-tools api-reports -o ae-wrong-input-file-type,ae-undocumented --validate-release-tags",
1515
"build:knip-reports": "backstage-repo-tools knip-reports",
1616
"tsc": "tsc",

workspaces/boost/packages/backend/Dockerfile

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# This dockerfile builds an image for the backend package.
22
# It should be executed with the root of the repo as docker context.
33
#
4+
# WARNING: This image bundles the workspace dev app-config.yaml (guest auth,
5+
# allow-all permissions, in-memory database). It is not production-ready
6+
# without supplying production app-config overrides.
7+
#
48
# Before building this image, be sure to have run the following commands in the repo root:
59
#
610
# yarn install --immutable
@@ -17,19 +21,11 @@ FROM node:24-trixie-slim
1721
# Set Python interpreter for `node-gyp` to use
1822
ENV PYTHON=/usr/bin/python3
1923

20-
# Install isolate-vm dependencies, these are needed by the @backstage/plugin-scaffolder-backend.
21-
RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
22-
--mount=type=cache,target=/var/lib/apt,sharing=locked \
23-
apt-get update && \
24-
apt-get install -y --no-install-recommends python3 g++ build-essential && \
25-
rm -rf /var/lib/apt/lists/*
26-
27-
# Install sqlite3 dependencies. You can skip this if you don't use sqlite3 in the image,
28-
# in which case you should also move better-sqlite3 to "devDependencies" in package.json.
24+
# Install isolate-vm and sqlite3 dependencies (needed by scaffolder and better-sqlite3).
2925
RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
3026
--mount=type=cache,target=/var/lib/apt,sharing=locked \
3127
apt-get update && \
32-
apt-get install -y --no-install-recommends libsqlite3-dev && \
28+
apt-get install -y --no-install-recommends python3 g++ build-essential libsqlite3-dev && \
3329
rm -rf /var/lib/apt/lists/*
3430

3531
# From here on we use the least-privileged `node` user to run the backend.

workspaces/boost/packages/backend/src/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ backend.add(import('@backstage/plugin-catalog-backend-module-logs'));
4949

5050
// permission plugin
5151
backend.add(import('@backstage/plugin-permission-backend'));
52-
// See https://backstage.io/docs/permissions/getting-started for how to create your own permission policy
52+
// Local dev only: allow-all-policy grants every permission to every caller.
53+
// Production deployments must register a real permission policy instead.
5354
backend.add(
5455
import('@backstage/plugin-permission-backend-module-allow-all-policy'),
5556
);

0 commit comments

Comments
 (0)