test: address PR review comments for orchestrator scaffolder actions

- Remove duplicated getError function
- Add test for undefined token response in getRequestConfigOption
- Remove redundant isDryRun assignment in runWorkflow.test.ts
- Add missing blank lines after license headers
- Use 'as any' instead of 'as never' in utils.test.ts
- Add changeset

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: rostalan

workspaces/orchestrator/.changeset/rhidp-9861-tests.md

@@ -0,0 +1,5 @@
+---
+'@red-hat-developer-hub/backstage-plugin-scaffolder-backend-module-orchestrator': patch
+---
+
+Added unit test coverage for orchestrator scaffolder actions and fixed token fallback logic.

workspaces/orchestrator/plugins/scaffolder-backend-module-orchestrator/src/actions/getWorkflowParams.test.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import { JsonObject } from '@backstage/types';
 
@@ -25,6 +26,7 @@ jest.mock('axios', () => ({
 }));
 
 jest.mock('./utils', () => ({
+  ...jest.requireActual('./utils'),
   getOrchestratorApi: jest.fn(),
   getRequestConfigOption: jest.fn(),
 }));

workspaces/orchestrator/plugins/scaffolder-backend-module-orchestrator/src/actions/getWorkflowParams.ts

@@ -18,22 +18,9 @@ import { DiscoveryApi } from '@backstage/plugin-permission-common';
 import { createTemplateAction } from '@backstage/plugin-scaffolder-node';
 import { JsonObject } from '@backstage/types';
 
-import { isAxiosError } from 'axios';
 import { dump } from 'js-yaml';
 
-import { getOrchestratorApi, getRequestConfigOption } from './utils';
-
-const getError = (err: unknown): Error => {
-  if (
-    isAxiosError<{ error: { message: string; name: string } }>(err) &&
-    err.response?.data?.error?.message
-  ) {
-    const error = new Error(err.response?.data?.error?.message);
-    error.name = err.response?.data?.error?.name || 'Error';
-    return error;
-  }
-  return err as Error;
-};
+import { getError, getOrchestratorApi, getRequestConfigOption } from './utils';
 
 const indentString = (str: string, indent: number) =>
   indent ? str.replace(/^/gm, ' '.repeat(indent)) : str;

workspaces/orchestrator/plugins/scaffolder-backend-module-orchestrator/src/actions/runWorkflow.test.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 
 import { createRunWorkflowAction } from './runWorkflow';
@@ -24,6 +25,7 @@ jest.mock('axios', () => ({
 }));
 
 jest.mock('./utils', () => ({
+  ...jest.requireActual('./utils'),
   getOrchestratorApi: jest.fn(),
   getRequestConfigOption: jest.fn(),
 }));
@@ -92,7 +94,6 @@ describe('createRunWorkflowAction', () => {
       templateInfo: {
         entityRef: 'component:default/sample-service',
       },
-      isDryRun: true,
       logger: {
         ...createMockActionContext().logger,
         info: loggerInfo,

workspaces/orchestrator/plugins/scaffolder-backend-module-orchestrator/src/actions/runWorkflow.ts

@@ -17,21 +17,7 @@ import { AuthService } from '@backstage/backend-plugin-api';
 import { DiscoveryApi } from '@backstage/plugin-permission-common';
 import { createTemplateAction } from '@backstage/plugin-scaffolder-node';
 
-import { isAxiosError } from 'axios';
-
-import { getOrchestratorApi, getRequestConfigOption } from './utils';
-
-const getError = (err: unknown): Error => {
-  if (
-    isAxiosError<{ error: { message: string; name: string } }>(err) &&
-    err.response?.data?.error?.message
-  ) {
-    const error = new Error(err.response?.data?.error?.message);
-    error.name = err.response?.data?.error?.name || 'Error';
-    return error;
-  }
-  return err as Error;
-};
+import { getError, getOrchestratorApi, getRequestConfigOption } from './utils';
 
 export function createRunWorkflowAction(
   discoveryService: DiscoveryApi,

workspaces/orchestrator/plugins/scaffolder-backend-module-orchestrator/src/actions/utils.test.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 import { AuthService } from '@backstage/backend-plugin-api';
 import { DiscoveryApi } from '@backstage/plugin-permission-common';
 
@@ -87,9 +88,9 @@ describe('utils', () => {
       const axiosInstance = { request: jest.fn() };
       const apiInstance = { executeWorkflow: jest.fn() };
 
-      mockedAxios.create.mockReturnValue(axiosInstance as never);
-      MockedConfiguration.mockImplementation(() => ({}) as never);
-      MockedDefaultApi.mockImplementation(() => apiInstance as never);
+      mockedAxios.create.mockReturnValue(axiosInstance as any);
+      MockedConfiguration.mockImplementation(() => ({}) as any);
+      MockedDefaultApi.mockImplementation(() => apiInstance as any);
 
       const api = await getOrchestratorApi(discoveryService);
 
@@ -159,5 +160,27 @@ describe('utils', () => {
         },
       });
     });
+
+    it('falls back to the backstage secret when the auth service returns undefined', async () => {
+      const ctx = {
+        getInitiatorCredentials: jest.fn().mockResolvedValue({
+          principal: 'user:default/bob',
+        }),
+        secrets: {
+          backstageToken: 'fallback-token',
+        },
+      };
+      const authService = {
+        getPluginRequestToken: jest.fn().mockResolvedValue(undefined),
+      } as unknown as jest.Mocked<AuthService>;
+
+      const config = await getRequestConfigOption(authService, ctx);
+
+      expect(config).toEqual({
+        headers: {
+          Authorization: 'Bearer fallback-token',
+        },
+      });
+    });
   });
 });