chore(extensions): fix sonarqube issue 'The return value of reduce must be used.'

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

Author: christoph-jerolimov

workspaces/extensions/e2e-tests/extensions.test.ts

@@ -60,14 +60,12 @@ test.describe('Admin > Extensions', () => {
       `^(${Object.values(LOCALE_DISPLAY_NAMES).map(escapeRegExp).join('|')})$`,
     );
 
-    // Navigating directly avoids flaky duplicate "Settings" links in sidebar.
-    await page.goto('/settings');
+    await page.locator('nav').getByRole('link', { name: 'Settings' });
     await page
       .getByRole('button', { name: localeDisplayPattern })
       .first()
       .click();
     await page.getByRole('option', { name: displayName }).click();
-    await page.goto('/');
   }
 
   test.beforeAll(async ({ browser }) => {

workspaces/extensions/e2e-tests/utils/translations.ts

@@ -26,35 +26,37 @@ import extensionsTranslationJa from '../../plugins/extensions/src/alpha/translat
 
 export type ExtensionsMessages = typeof extensionsMessages;
 
-function transform(messages: typeof extensionsTranslationDe.messages) {
-  const result = Object.keys(messages).reduce((res, key) => {
+function transformFlatMessagesIntoTree(
+  flatMessages: typeof extensionsTranslationDe.messages,
+) {
+  const messages = {} as Record<string, any>;
+  for (const key of Object.keys(flatMessages)) {
     const path = key.split('.');
-    const lastIndex = path.length - 1;
-    path.reduce((acc, currentPath, i) => {
-      acc[currentPath] =
-        lastIndex === i ? messages[key] : acc[currentPath] || {};
-      return acc[currentPath];
-    }, res);
-    return res;
-  }, {});
-
-  return result as ExtensionsMessages;
+    let current = messages;
+    for (let i = 0; i < path.length - 1; i++) {
+      current[path[i]] = current[path[i]] || {};
+      current = current[path[i]] as Record<string, any>;
+    }
+    current[path[path.length - 1]] =
+      flatMessages[key as keyof typeof flatMessages];
+  }
+  return messages as ExtensionsMessages;
 }
 
 export function getTranslations(locale: string) {
   switch (locale) {
     case 'en':
       return extensionsMessages;
     case 'de':
-      return transform(extensionsTranslationDe.messages);
+      return transformFlatMessagesIntoTree(extensionsTranslationDe.messages);
     case 'es':
-      return transform(extensionsTranslationEs.messages);
+      return transformFlatMessagesIntoTree(extensionsTranslationEs.messages);
     case 'fr':
-      return transform(extensionsTranslationFr.messages);
+      return transformFlatMessagesIntoTree(extensionsTranslationFr.messages);
     case 'it':
-      return transform(extensionsTranslationIt.messages);
+      return transformFlatMessagesIntoTree(extensionsTranslationIt.messages);
     case 'ja':
-      return transform(extensionsTranslationJa.messages);
+      return transformFlatMessagesIntoTree(extensionsTranslationJa.messages);
     default:
       return extensionsMessages;
   }