Skip to content

fix: allow properly quoted LoqQL querys in the selector field.#3533

Merged
karthikjeeyar merged 1 commit into
redhat-developer:mainfrom
lholmquist:RHDHSUPP-381-loki-regression
Jun 23, 2026
Merged

fix: allow properly quoted LoqQL querys in the selector field.#3533
karthikjeeyar merged 1 commit into
redhat-developer:mainfrom
lholmquist:RHDHSUPP-381-loki-regression

Conversation

@lholmquist

@lholmquist lholmquist commented Jun 22, 2026

Copy link
Copy Markdown
Member

fixes https://redhat.atlassian.net/browse/RHDHSUPP-381

assisted by cursor

This will also need to be backported to 1.10.x

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app

rhdh-gh-app Bot commented Jun 22, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-orchestrator-backend-module-loki workspaces/orchestrator/plugins/orchestrator-backend-module-loki patch v1.3.0

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.64%. Comparing base (22f75ad) to head (be44299).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3533   +/-   ##
=======================================
  Coverage   53.63%   53.64%           
=======================================
  Files        2260     2260           
  Lines       85976    85998   +22     
  Branches    24217    24221    +4     
=======================================
+ Hits        46116    46134   +18     
- Misses      39574    39581    +7     
+ Partials      286      283    -3     
Flag Coverage Δ *Carryforward flag
adoption-insights 83.70% <ø> (ø) Carriedforward from 22f75ad
ai-integrations 67.95% <ø> (ø) Carriedforward from 22f75ad
app-defaults 69.79% <ø> (ø) Carriedforward from 22f75ad
augment 46.39% <ø> (ø) Carriedforward from 22f75ad
boost 74.64% <ø> (ø) Carriedforward from 22f75ad
bulk-import 72.46% <ø> (ø) Carriedforward from 22f75ad
cost-management 14.10% <ø> (ø) Carriedforward from 22f75ad
dcm 61.79% <ø> (ø) Carriedforward from 22f75ad
extensions 61.53% <ø> (ø) Carriedforward from 22f75ad
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 22f75ad
global-header 59.71% <ø> (ø) Carriedforward from 22f75ad
homepage 49.84% <ø> (ø) Carriedforward from 22f75ad
install-dynamic-plugins 56.23% <ø> (ø) Carriedforward from 22f75ad
konflux 91.49% <ø> (ø) Carriedforward from 22f75ad
lightspeed 68.57% <ø> (ø) Carriedforward from 22f75ad
mcp-integrations 85.46% <ø> (ø) Carriedforward from 22f75ad
orchestrator 37.95% <84.61%> (+0.15%) ⬆️
quickstart 63.76% <ø> (ø) Carriedforward from 22f75ad
sandbox 79.56% <ø> (ø) Carriedforward from 22f75ad
scorecard 83.96% <ø> (ø) Carriedforward from 22f75ad
theme 61.26% <ø> (ø) Carriedforward from 22f75ad
translations 7.25% <ø> (ø) Carriedforward from 22f75ad
x2a 78.68% <ø> (ø) Carriedforward from 22f75ad

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f75ad...be44299. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@karthikjeeyar karthikjeeyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 23, 2026
@karthikjeeyar karthikjeeyar merged commit e6d1c2d into redhat-developer:main Jun 23, 2026
24 checks passed
@sonarqubecloud

Copy link
Copy Markdown

karthikjeeyar pushed a commit that referenced this pull request Jun 26, 2026
* bump fast-uri (#3454)

* [release-1.10] chore(deps): bump Orchestrator deps to resolve 1.10.2 CVEs (#3537)

Signed-off-by: Jessica He <jhe@redhat.com>

* fix: allow properly quoted LoqQL querys in the selector field. (#3533) (#3552)

fixes https://redhat.atlassian.net/browse/RHDHSUPP-381

assisted by cursor

---------

Signed-off-by: Jessica He <jhe@redhat.com>
Co-authored-by: André <alizardo@redhat.com>
Co-authored-by: Jessica He <jhe@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants