Skip to content

chore(release): cherry-pick fix for is_version_pr typo on workspace/bulk-import#3601

Merged
its-mitesh-kumar merged 1 commit into
redhat-developer:workspace/bulk-importfrom
its-mitesh-kumar:fix/bulk-import-release-workflow
Jun 26, 2026
Merged

chore(release): cherry-pick fix for is_version_pr typo on workspace/bulk-import#3601
its-mitesh-kumar merged 1 commit into
redhat-developer:workspace/bulk-importfrom
its-mitesh-kumar:fix/bulk-import-release-workflow

Conversation

@its-mitesh-kumar

@its-mitesh-kumar its-mitesh-kumar commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

The workspace/bulk-import branch has its own copy of release_workspace_version.yml that was last updated by #2150 (Jan 28, 2026). The typo fix #2468 — which adds the missing $ in "PR_MERGED" vs "$PR_MERGED" — was merged to main on Mar 5, 2026, but was never cherry-picked to workspace/bulk-import.

Without this fix, is_version_pr always evaluates to false, so the release/publish job is skipped entirely. When I created and merged the Version Packages PR #3568 targeting workspace/bulk-import, the workflow picked up the buggy version of the file from that branch. It ran the wrong job (changesets-pr instead of release) and errored out because the maintenance-changesets-release/bulk-import branch already existed.

This PR cherry-picks commit a8cd84b from main onto workspace/bulk-import to fix the issue. Once merged, we need to:

  1. Delete the stale maintenance-changesets-release/bulk-import remote branch
  2. Re-trigger the Version Packages flow to publish 7.0.2 to npm
  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

…evaluated (redhat-developer#2468)

Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
@its-mitesh-kumar its-mitesh-kumar requested review from a team as code owners June 26, 2026 05:53
@its-mitesh-kumar its-mitesh-kumar changed the title chore(release): cherry-pick fix for is_version_pr typo on workspace/bulk-import" \ chore(release): cherry-pick fix for is_version_pr typo on workspace/bulk-import Jun 26, 2026
@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

/cc @hopehadfield

@openshift-ci openshift-ci Bot requested a review from hopehadfield June 26, 2026 05:54

@invincibleJai invincibleJai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 26, 2026
@its-mitesh-kumar its-mitesh-kumar merged commit 5d7cc73 into redhat-developer:workspace/bulk-import Jun 26, 2026
8 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants