Skip to content

Latest commit

 

History

History
87 lines (58 loc) · 3.46 KB

File metadata and controls

87 lines (58 loc) · 3.46 KB
name rhdh-pr-review
description Test PR changes on a live RHDH cluster. Fetches CI-built images from PR comments, checks cluster status (deploying if needed), deploys the full PR operator bundle or manifests (not just image swap), actively verifies the code changes by exercising affected code paths on the cluster, and closes with findings including best-practice and security assessment. Use when asked to review an rhdh-operator PR, test PR changes on a cluster, deploy PR images for testing, or deploy PR bundle. Also use when user mentions "operator PR", "review PR", or "test this PR on my cluster". Currently supports rhdh-operator PRs.

<cli_setup> This skill uses the orchestrator CLI for activity tracking. Set up first:

RHDH=../rhdh/scripts/rhdh

</cli_setup>

<essential_principles>

Always verify the user has a running RHDH cluster with `oc` access before deploying PR bundles. If no cluster or no RHDH instance, provision one using `redhat-developer/rhdh-test-instance` — see `rhdh-repos.md` for details on that repo's capabilities. Don't just tell the user to set things up — do it. Extract image URLs from PR comments posted by CI — never construct image URLs manually. The tag format includes PR number + commit SHA, which only CI knows. See `references/operator-pr-images.md` for extraction commands. Deploy the full PR bundle/manifests, not just the operator binary image. PR changes to CRDs, RBAC, default config, or bundle metadata are baked into the OLM bundle or install.yaml manifests — a binary-only image swap misses them and the operator may fail to reconcile. For OLM-managed installs, replace the CatalogSource with the PR's `operator-catalog` image so OLM reinstalls the full bundle (CRDs, RBAC, CSV, deployment). For non-OLM installs, fetch and apply the PR branch's `install.yaml` (CRDs, RBAC, ConfigMaps, Deployment) with the CI-built operator image substituted in. Both paths preserve existing Backstage CRs, config, and Keycloak state — only the operator-side resources are replaced.

</essential_principles>

What would you like to do?

PR Review Tasks

For testing PR changes on a live RHDH cluster

  1. Review rhdh-operator PR — Deploy PR operator bundle on cluster and get review checklist

Wait for response before proceeding.

PR Review Routes

Response Workflow
1, "operator", "rhdh-operator", a PR number, "review" Route to workflows/review-operator-pr.md

To route: Read workflows/review-operator-pr.md and follow its process.

<reference_index>

Reference Purpose Path
operator-pr-images CI image extraction and validation references/operator-pr-images.md
github-reference gh CLI patterns, PR queries ../rhdh/references/github-reference.md (if unavailable, use standard gh CLI patterns)
rhdh-repos RHDH ecosystem repository map ../rhdh/references/rhdh-repos.md (if unavailable, see CONTEXT.md for repo list)

</reference_index>

<skills_index>

Skill Purpose Path
rhdh Orchestrator, environment status, activity tracking ../rhdh/SKILL.md

</skills_index>

<success_criteria>

See workflows/review-operator-pr.md <success_criteria> for the full checklist.

</success_criteria>