Skip to content

Commit 04e365a

Browse files
zdrapeladurandom
authored andcommitted
fix(prow): add --reference format validation to generate_cluster_pool.py
Validate that --reference matches X.Y format before splitting, matching the existing validation in generate_test_entry.py. Previously, a malformed --reference value would crash at split('.'). Addresses non-blocking review item from PR #25. Assisted-by: OpenCode
1 parent d1d405c commit 04e365a

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

skills/prow/scripts/generate_cluster_pool.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,11 @@ def main(argv=None):
6363
print(f"ERROR: Version must be in X.Y format, got: {args.version}", file=sys.stderr)
6464
sys.exit(1)
6565

66+
if args.reference:
67+
if not re.match(r"^\d+\.\d+$", args.reference):
68+
print(f"ERROR: Reference must be in X.Y format, got: {args.reference}", file=sys.stderr)
69+
sys.exit(1)
70+
6671
major, minor = args.version.split(".")
6772
next_minor = str(int(minor) + 1)
6873
dash_ver = f"{major}-{minor}"

0 commit comments

Comments
 (0)