test: update tests for repo cleanup

- Rewrite test_claude_md.py → test AGENTS.md structure and CLAUDE.md symlink
- Remove TestCommandFiles and TestSettingsJson from test_marketplace.py
  (commands/ and .claude/ directories removed)
- Fix UTF-8 encoding in test_skill_structure.py read_text() calls

Author: schultzp2020

tests/unit/test_claude_md.py

@@ -1,43 +1,56 @@
-"""Tests for CLAUDE.md structure and content."""
+"""Tests for AGENTS.md (and CLAUDE.md symlink) structure and content."""
 
 import pytest
 
 
-class TestClaudeMdStructure:
-    """Test that CLAUDE.md has required structure."""
+class TestAgentsMdStructure:
+    """Test that AGENTS.md has required structure."""
 
     @pytest.fixture
-    def claude_md(self, skill_root):
-        """Load CLAUDE.md content."""
+    def agents_md(self, skill_root):
+        """Load AGENTS.md content."""
+        agents_path = skill_root / "AGENTS.md"
+        assert agents_path.exists(), "AGENTS.md must exist at project root"
+        return agents_path.read_text()
+
+    def test_agents_md_exists(self, skill_root):
+        """AGENTS.md must exist at project root."""
+        assert (skill_root / "AGENTS.md").exists()
+
+    def test_claude_md_symlink_exists(self, skill_root):
+        """CLAUDE.md should exist as a symlink to AGENTS.md."""
         claude_path = skill_root / "CLAUDE.md"
         assert claude_path.exists(), "CLAUDE.md must exist at project root"
-        return claude_path.read_text()
-
-    def test_claude_md_exists(self, skill_root):
-        """CLAUDE.md must exist at project root."""
-        assert (skill_root / "CLAUDE.md").exists()
-
-    def test_has_tdd_rule(self, claude_md):
-        """CLAUDE.md must mention TDD-first development."""
-        assert "TDD" in claude_md
-        assert "test" in claude_md.lower()
-
-    def test_references_test_file(self, claude_md):
-        """CLAUDE.md should reference test examples."""
-        assert "test_skill_structure.py" in claude_md
-
-    def test_has_project_structure(self, claude_md):
-        """CLAUDE.md should document project structure."""
-        assert "rhdh/" in claude_md
-        assert "skills/" in claude_md
-        assert "tests/" in claude_md
-
-    def test_has_cli_section(self, claude_md):
-        """CLAUDE.md should document CLI usage."""
-        assert "rhdh" in claude_md
-        assert "uv run" in claude_md
-
-    def test_documents_output_format(self, claude_md):
-        """CLAUDE.md should explain JSON/human output detection."""
-        assert "JSON" in claude_md
-        assert "TTY" in claude_md or "human" in claude_md.lower()
+
+    def test_has_think_before_coding_rule(self, agents_md):
+        """AGENTS.md must mention think before coding."""
+        assert "Think Before Coding" in agents_md
+
+    def test_has_simplicity_rule(self, agents_md):
+        """AGENTS.md must mention simplicity first."""
+        assert "Simplicity First" in agents_md
+
+    def test_has_surgical_changes_rule(self, agents_md):
+        """AGENTS.md must mention surgical changes."""
+        assert "Surgical Changes" in agents_md
+
+    def test_has_goal_driven_rule(self, agents_md):
+        """AGENTS.md must mention goal-driven execution."""
+        assert "Goal-Driven Execution" in agents_md
+
+    def test_has_verification_command(self, agents_md):
+        """AGENTS.md should reference test verification."""
+        assert "uv run pytest" in agents_md
+
+    def test_has_versioning_section(self, agents_md):
+        """AGENTS.md should document versioning."""
+        assert "pyproject.toml" in agents_md
+        assert "plugin.json" in agents_md
+        assert "marketplace.json" in agents_md
+
+    def test_has_agent_skills_section(self, agents_md):
+        """AGENTS.md should have agent skills config section."""
+        assert "## Agent skills" in agents_md
+        assert "issue-tracker.md" in agents_md
+        assert "triage-labels.md" in agents_md
+        assert "domain.md" in agents_md

tests/unit/test_marketplace.py

@@ -1,10 +1,8 @@
 """Tests for marketplace configuration files."""
 
 import json
-import re
 
 import pytest
-import yaml
 
 
 class TestPluginJson:
@@ -81,76 +79,3 @@ def test_plugin_entry_has_required_fields(self, marketplace_json):
             assert "name" in plugin
             assert "source" in plugin
             assert "version" in plugin
-
-
-class TestCommandFiles:
-    """Test command files have proper structure."""
-
-    @pytest.fixture
-    def command_files(self, skill_root):
-        """Get all command files."""
-        commands_dir = skill_root / "commands"
-        return list(commands_dir.glob("*.md"))
-
-    def test_commands_exist(self, command_files):
-        """At least one command should exist."""
-        assert len(command_files) >= 1
-
-    def test_command_has_frontmatter(self, command_files):
-        """Each command should have YAML frontmatter."""
-        for cmd in command_files:
-            content = cmd.read_text()
-            match = re.match(r"^---\n(.*?)\n---", content, re.DOTALL)
-            assert match, f"{cmd.name} missing YAML frontmatter"
-
-            frontmatter = yaml.safe_load(match.group(1))
-            assert "description" in frontmatter, f"{cmd.name} missing description"
-
-    def test_command_has_allowed_tools(self, command_files):
-        """Each command should specify allowed-tools."""
-        for cmd in command_files:
-            content = cmd.read_text()
-            match = re.match(r"^---\n(.*?)\n---", content, re.DOTALL)
-            assert match, f"{cmd.name} missing YAML frontmatter"
-            frontmatter = yaml.safe_load(match.group(1))
-
-            assert "allowed-tools" in frontmatter, f"{cmd.name} missing allowed-tools"
-            # Should reference the skill
-            assert "Skill" in frontmatter["allowed-tools"], (
-                f"{cmd.name} allowed-tools should reference Skill"
-            )
-
-
-class TestSettingsJson:
-    """Test .claude/settings.json structure."""
-
-    @pytest.fixture
-    def settings_json(self, skill_root):
-        """Load settings.json content."""
-        path = skill_root / ".claude" / "settings.json"
-        return json.loads(path.read_text())
-
-    def test_has_commands(self, settings_json):
-        """settings.json should have commands section."""
-        assert "commands" in settings_json
-        assert len(settings_json["commands"]) >= 1
-
-    def test_has_skills(self, settings_json):
-        """settings.json should have skills section."""
-        assert "skills" in settings_json
-        assert "rhdh" in settings_json["skills"]
-
-    def test_skill_has_path(self, settings_json):
-        """Skill entry should have path."""
-        skill = settings_json["skills"]["rhdh"]
-        assert "path" in skill
-
-    def test_command_paths_are_valid(self, settings_json, skill_root):
-        """Command paths should resolve to existing files."""
-        claude_dir = skill_root / ".claude"
-
-        for name, cmd in settings_json["commands"].items():
-            if "path" in cmd:
-                # Resolve relative path from .claude/
-                cmd_path = (claude_dir / cmd["path"]).resolve()
-                assert cmd_path.exists(), f"Command {name} path does not exist: {cmd_path}"

tests/unit/test_skill_structure.py

@@ -13,7 +13,7 @@ class TestOrchestratorSkillMd:
     def skill_md(self, skills_dir):
         """Load orchestrator SKILL.md content."""
         skill_path = skills_dir / "SKILL.md"
-        return skill_path.read_text()
+        return skill_path.read_text(encoding="utf-8")
 
     @pytest.fixture
     def skill_frontmatter(self, skill_md):
@@ -81,7 +81,7 @@ class TestOverlaySkillMd:
     def skill_md(self, overlay_skill_dir):
         """Load overlay SKILL.md content."""
         skill_path = overlay_skill_dir / "SKILL.md"
-        return skill_path.read_text()
+        return skill_path.read_text(encoding="utf-8")
 
     @pytest.fixture
     def skill_frontmatter(self, skill_md):
@@ -181,22 +181,22 @@ def test_workflows_exist(self, workflow_files):
     def test_workflow_has_required_reading(self, workflow_files):
         """Each workflow should have <required_reading> section."""
         for workflow in workflow_files:
-            content = workflow.read_text()
+            content = workflow.read_text(encoding="utf-8")
             assert "<required_reading>" in content or "<prerequisites>" in content, (
                 f"{workflow.name} missing required_reading or prerequisites"
             )
 
     def test_workflow_has_process(self, workflow_files):
         """Each workflow should have <process> section."""
         for workflow in workflow_files:
-            content = workflow.read_text()
+            content = workflow.read_text(encoding="utf-8")
             assert "<process>" in content, f"{workflow.name} missing <process> section"
             assert "</process>" in content, f"{workflow.name} missing </process> closing tag"
 
     def test_workflow_has_success_criteria(self, workflow_files):
         """Each workflow should have <success_criteria> section."""
         for workflow in workflow_files:
-            content = workflow.read_text()
+            content = workflow.read_text(encoding="utf-8")
             assert "<success_criteria>" in content, (
                 f"{workflow.name} missing <success_criteria> section"
             )
@@ -210,7 +210,7 @@ def rhdh_repos(self, skills_dir):
         """Load rhdh-repos.md content."""
         path = skills_dir / "references" / "rhdh-repos.md"
         assert path.exists(), "rhdh-repos.md must exist in skills/rhdh/references/"
-        return path.read_text()
+        return path.read_text(encoding="utf-8")
 
     def test_rhdh_repos_exists(self, skills_dir):
         """rhdh-repos.md must exist."""
@@ -268,7 +268,7 @@ def test_reference_has_xml_sections(self, reference_files):
         for ref in reference_files:
             if ref.name in xml_optional:
                 continue
-            content = ref.read_text()
+            content = ref.read_text(encoding="utf-8")
             # Should have at least one XML tag
             has_xml = bool(re.search(r"<\w+>", content))
             assert has_xml, f"{ref.name} should use XML tags for structure"
@@ -290,5 +290,5 @@ def test_templates_exist(self, template_files):
     def test_template_has_code_blocks(self, template_files):
         """Templates should contain code block examples."""
         for template in template_files:
-            content = template.read_text()
+            content = template.read_text(encoding="utf-8")
             assert "```" in content, f"{template.name} should have code block examples"