You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: skills/bug-fix/SKILL.md
+22-3Lines changed: 22 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -23,6 +23,21 @@ Do not hardcode workspace internals. Discover each workspace's e2e infrastructur
23
23
Every bug fix PR must include before/after visual evidence. Playwright video recording captures the bug in action (before) and the fix working (after). These are converted to GIFs and embedded in the PR description.
24
24
</principle>
25
25
26
+
<principlename="step_echo_banners">
27
+
Before executing each numbered Step, echo a clearly visible banner to the terminal so the user can track progress:
28
+
```
29
+
echo "================ Step N — <Step title> ==========="
30
+
```
31
+
</principle>
32
+
33
+
<principlename="preflight_port_cleanup">
34
+
Before running any Playwright test, check whether the dev-server port (from `playwright.config.ts`) is already in use. If it is, kill the process occupying it:
4. Run the test against the `en` locale in legacy mode:
92
111
```
93
112
APP_MODE=legacy npx playwright test e2e-tests/_repro-<KEY>.test.ts --project=en
94
113
```
95
-
4. The test should **fail** — confirming the bug is reproduced.
114
+
5. The test should **fail** — confirming the bug is reproduced.
96
115
97
116
**If the test passes** (bug not reproduced): re-read the Jira description, adjust the test, and retry. If still not reproducible after 2 attempts, report findings and ask the user for guidance.
98
117
@@ -194,7 +213,7 @@ Invoke `raise-pr --a` with the following caller context:
Copy file name to clipboardExpand all lines: skills/raise-pr/SKILL.md
+10-3Lines changed: 10 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -14,7 +14,7 @@ description: >
14
14
<essential_principles>
15
15
16
16
<principlename="scoped_dist_cleanup">
17
-
Pre-build cleanup uses `rm -rf plugins/*/dist packages/*/dist` scoped to the workspace directory. If permission errors occur, escalate to`sudo`. Never use `find -name dist` or any broad recursive search — that deletes `dist/` inside `node_modules` and breaks everything.
17
+
Pre-build cleanup uses `rm -rf plugins/*/dist packages/*/dist` scoped to the workspace directory. If permission errors occur (root-owned files from a prior Docker build), use a disposable Docker container to remove them — never use`sudo`. Never use `find -name dist` or any broad recursive search — that deletes `dist/` inside `node_modules` and breaks everything.
18
18
</principle>
19
19
20
20
<principlename="changesets_skip_packages">
@@ -25,6 +25,13 @@ Only plugins under `plugins/*` with published-source changes need changesets. Al
25
25
Capture `git status --porcelain` before builds as the baseline. After builds, only stage files that are new relative to that baseline. Pre-existing dirty files (local config overrides, dev fixtures) must never be staged.
26
26
</principle>
27
27
28
+
<principlename="step_echo_banners">
29
+
Before executing each numbered Step, echo a clearly visible banner to the terminal so the user can track progress:
30
+
```
31
+
echo "================ Step N — <Step title> ==========="
32
+
```
33
+
</principle>
34
+
28
35
</essential_principles>
29
36
30
37
## Mode: check for `--a` flag
@@ -113,10 +120,10 @@ Remove stale `dist/` directories that may contain root-owned files from previous
113
120
rm -rf plugins/*/dist packages/*/dist
114
121
```
115
122
116
-
If this fails with a permission error (`EACCES`), escalate to:
123
+
If this fails with a permission error (`EACCES`), use a disposable Docker container to remove them (avoids needing `sudo` on the host):
117
124
118
125
```
119
-
sudo rm -rf plugins/*/dist packages/*/dist
126
+
docker run --rm -v "$(pwd)":/workspace alpine sh -c "rm -rf /workspace/plugins/*/dist /workspace/packages/*/dist"
0 commit comments